From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40729)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YBgQI-0008AK-MY
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 04:09:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YBgQF-0004Mm-HI
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 04:09:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35096)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YBgQF-0004Mg-9R
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 04:08:59 -0500
Message-ID: <54B7839E.5020903@redhat.com>
Date: Thu, 15 Jan 2015 10:08:46 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1420948672-50103-1-git-send-email-sfeldma@gmail.com>	<1420948672-50103-7-git-send-email-sfeldma@gmail.com>	<54B3C4C6.2000703@redhat.com>
	<CAE4R7bAyJqdLvT_ux927v0bww5GrS6b0kr-qUkX=gHhQxuS=1Q@mail.gmail.com>
In-Reply-To: <CAE4R7bAyJqdLvT_ux927v0bww5GrS6b0kr-qUkX=gHhQxuS=1Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 6/9] rocker: add new rocker switch device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Scott Feldman <sfeldma@gmail.com>
Cc: =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= <jiri@resnulli.us>, Stefan Hajnoczi <stefanha@gmail.com>, Roopa Prabhu <roopa@cumulusnetworks.com>, john fastabend <john.fastabend@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>



On 15/01/2015 00:20, Scott Feldman wrote:
> I tried setting .impl.max_access_size=4 and the Linux driver self-test
> fails on 64-bit reg write/read.  32-bit regs writes/reads are OK.  On
> the 64-bit write/read, the self test writes a value and expects to
> read back 2x the value written.  After making the change
> .impl.max_access_size=4, the reg reads back as 0, regardless of what
> was written.

It would be a bug.  I can try to look at it later.

Paolo

> The driver uses writeq/readq for 64-bit writes/reads.
> 
> I'm inclined to not change the device and leave .impl.max_access_size=8.