From: Paolo Bonzini <pbonzini@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] vmstate: accept QEMUTimer in VMSTATE_TIMER*, add VMSTATE_TIMER_PTR*
Date: Thu, 15 Jan 2015 10:14:54 +0100 [thread overview]
Message-ID: <54B7850E.9010408@redhat.com> (raw)
In-Reply-To: <20150115090414.GA6102@grmbl.mre>
On 15/01/2015 10:04, Amit Shah wrote:
>
>> > diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
>> > index e45fc49..55ba584 100644
>> > --- a/include/migration/vmstate.h
>> > +++ b/include/migration/vmstate.h
>> > @@ -642,17 +642,29 @@ extern const VMStateInfo vmstate_info_bitmap;
>> > #define VMSTATE_FLOAT64(_f, _s) \
>> > VMSTATE_FLOAT64_V(_f, _s, 0)
>> >
>> > -#define VMSTATE_TIMER_TEST(_f, _s, _test) \
>> > +#define VMSTATE_TIMER_PTR_TEST(_f, _s, _test) \
>> > VMSTATE_POINTER_TEST(_f, _s, _test, vmstate_info_timer, QEMUTimer *)
>> >
>> > -#define VMSTATE_TIMER_V(_f, _s, _v) \
>> > +#define VMSTATE_TIMER_PTR_V(_f, _s, _v) \
>> > VMSTATE_POINTER(_f, _s, _v, vmstate_info_timer, QEMUTimer *)
>> >
>> > +#define VMSTATE_TIMER_PTR(_f, _s) \
>> > + VMSTATE_TIMER_PTR_V(_f, _s, 0)
>> > +
>> > +#define VMSTATE_TIMER_PTR_ARRAY(_f, _s, _n) \
>> > + VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer *)
>> > +
>> > +#define VMSTATE_TIMER_TEST(_f, _s, _test) \
>> > + VMSTATE_SINGLE_TEST(_f, _s, _test, 0, vmstate_info_timer, QEMUTimer)
>> > +
>> > +#define VMSTATE_TIMER_V(_f, _s, _v) \
>> > + VMSTATE_SINGLE(_f, _s, _v, vmstate_info_timer, QEMUTimer)
>> > +
>> > #define VMSTATE_TIMER(_f, _s) \
>> > VMSTATE_TIMER_V(_f, _s, 0)
> Why leave this around?
Because further changes down the line will convert QEMUTimer* to
QEMUTimer and thus go back to VMSTATE_TIMER. Having both around avoids
having a single patch with -1000/+1000 diffstat.
Paolo
next prev parent reply other threads:[~2015-01-15 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 10:03 [Qemu-devel] [PATCH 0/4] qemu-timer: introduce usable pointer-free API Paolo Bonzini
2015-01-08 10:03 ` [Qemu-devel] [PATCH 1/4] qemu-timer: rename timer_init to timer_init_tl Paolo Bonzini
2015-01-08 10:03 ` [Qemu-devel] [PATCH 2/4] qemu-timer: add timer_init and timer_init_ns/us/ms Paolo Bonzini
2015-01-09 2:19 ` Fam Zheng
2015-01-09 10:39 ` Paolo Bonzini
2015-01-08 10:03 ` [Qemu-devel] [PATCH 3/4] qemu-timer: introduce timer_deinit Paolo Bonzini
2015-01-08 10:03 ` [Qemu-devel] [PATCH 4/4] vmstate: accept QEMUTimer in VMSTATE_TIMER*, add VMSTATE_TIMER_PTR* Paolo Bonzini
2015-01-15 9:04 ` Amit Shah
2015-01-15 9:14 ` Paolo Bonzini [this message]
2015-01-09 2:10 ` [Qemu-devel] [PATCH 0/4] qemu-timer: introduce usable pointer-free API Fam Zheng
2015-01-09 9:07 ` Paolo Bonzini
2015-01-10 1:35 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B7850E.9010408@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).