qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>,
	Frederic Konrad <fred.konrad@greensocs.com>,
	mttcg@greensocs.com, qemu-devel <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] global_mutex and multithread.
Date: Thu, 15 Jan 2015 12:26:32 +0100	[thread overview]
Message-ID: <54B7A3E8.4000300@redhat.com> (raw)
In-Reply-To: <54B7A124.3020300@suse.de>



On 15/01/2015 12:14, Alexander Graf wrote:
>> > 
>> > Once you have >1 VCPU thread you'll need the RCU work that I am slowly
>> > polishing and sending out.  That's because one device can change the
>> > memory map, and that will cause a tlb_flush for all CPUs in tcg_commit,
>> > and that's not thread-safe.
> You'll have a similar problem for tb_flush() if you use a single tb
> cache. Just introduce a big hammer function for now that IPIs all the
> other threads, waits until they halted, do the atomic instruction (like
> change the memory map or flush the tb cache), then let them continue.

For the memory map I played with just using cpu_interrupt instead of
waiting for the halt of the other CPUs.  That's safe for 1 VCPU thread,
but not for >1 thread.  Perhaps we can exit the other CPUs with a signal
and cpu_resume_from_signal.

Paolo

  reply	other threads:[~2015-01-15 11:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 10:25 [Qemu-devel] global_mutex and multithread Frederic Konrad
2015-01-15 10:34 ` Peter Maydell
2015-01-15 10:41   ` Frederic Konrad
2015-01-15 10:44 ` Paolo Bonzini
2015-01-15 11:12 ` Paolo Bonzini
2015-01-15 11:14   ` Alexander Graf
2015-01-15 11:26     ` Paolo Bonzini [this message]
2015-01-15 13:30     ` Frederic Konrad
2015-01-15 13:34       ` Mark Burton
2015-01-15 12:51   ` Frederic Konrad
2015-01-15 12:56     ` Paolo Bonzini
2015-01-15 13:27       ` Frederic Konrad
2015-01-15 13:30         ` Peter Maydell
2015-01-15 19:07   ` Mark Burton
2015-01-15 20:27     ` Paolo Bonzini
2015-01-15 20:53       ` Mark Burton
2015-01-15 21:41         ` Paolo Bonzini
2015-01-15 21:41         ` Paolo Bonzini
2015-01-16  7:25           ` Mark Burton
2015-01-16  8:07             ` Jan Kiszka
2015-01-16  8:43               ` Frederic Konrad
2015-01-16  8:52               ` Mark Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B7A3E8.4000300@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=fred.konrad@greensocs.com \
    --cc=mttcg@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).