From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC3Al-0003k6-0I for qemu-devel@nongnu.org; Fri, 16 Jan 2015 04:26:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YC3Ah-0007WR-IN for qemu-devel@nongnu.org; Fri, 16 Jan 2015 04:26:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC3Ah-0007WM-Ak for qemu-devel@nongnu.org; Fri, 16 Jan 2015 04:26:27 -0500 Message-ID: <54B8D939.2020603@redhat.com> Date: Fri, 16 Jan 2015 17:26:17 +0800 From: Jason Wang MIME-Version: 1.0 References: <1420948672-50103-1-git-send-email-sfeldma@gmail.com> <1420948672-50103-8-git-send-email-sfeldma@gmail.com> In-Reply-To: <1420948672-50103-8-git-send-email-sfeldma@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 7/9] qmp: add rocker device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com, qemu-devel@nongnu.org, jiri@resnulli.us, roopa@cumulusnetworks.com, john.fastabend@gmail.com, eblake@redhat.com, pbonzini@redhat.com, stefanha@gmail.com On 01/11/2015 11:57 AM, sfeldma@gmail.com wrote: > From: Scott Feldman > > Add QMP/HMP support for rocker devices. This is mostly for debugging purposes > to see inside the device's tables and port configurations. Some examples: > > (qemu) info rocker sw1 > name: sw1 > id: 0x0000013512005452 > ports: 4 > > (qemu) info rocker-ports sw1 > ena/ speed/ auto > port link duplex neg? > sw1.1 up 10G FD No > sw1.2 up 10G FD No > sw1.3 !ena 10G FD No > sw1.4 !ena 10G FD No > > (qemu) info rocker-of-dpa-flows sw1 > prio tbl hits key(mask) --> actions > 2 60 lport 1 vlan 1 LLDP src 00:02:00:00:02:00 dst 01:80:c2:00:00:0e > 2 60 lport 1 vlan 1 ARP src 00:02:00:00:02:00 dst 00:02:00:00:03:00 > 2 60 lport 2 vlan 2 IPv6 src 00:02:00:00:03:00 dst 33:33:ff:00:00:02 proto 58 > 3 50 vlan 2 dst 33:33:ff:00:00:02 --> write group 0x32000001 goto tbl 60 > 2 60 lport 2 vlan 2 IPv6 src 00:02:00:00:03:00 dst 33:33:ff:00:03:00 proto 58 > 3 50 1 vlan 2 dst 33:33:ff:00:03:00 --> write group 0x32000001 goto tbl 60 > 2 60 lport 2 vlan 2 ARP src 00:02:00:00:03:00 dst 00:02:00:00:02:00 > 3 50 2 vlan 2 dst 00:02:00:00:02:00 --> write group 0x02000001 goto tbl 60 > 2 60 1 lport 2 vlan 2 IP src 00:02:00:00:03:00 dst 00:02:00:00:02:00 proto 1 > 3 50 2 vlan 1 dst 00:02:00:00:03:00 --> write group 0x01000002 goto tbl 60 > 2 60 1 lport 1 vlan 1 IP src 00:02:00:00:02:00 dst 00:02:00:00:03:00 proto 1 > 2 60 lport 1 vlan 1 IPv6 src 00:02:00:00:02:00 dst 33:33:ff:00:00:01 proto 58 > 3 50 vlan 1 dst 33:33:ff:00:00:01 --> write group 0x31000000 goto tbl 60 > 2 60 lport 1 vlan 1 IPv6 src 00:02:00:00:02:00 dst 33:33:ff:00:02:00 proto 58 > 3 50 1 vlan 1 dst 33:33:ff:00:02:00 --> write group 0x31000000 goto tbl 60 > 1 60 173 lport 2 vlan 2 LLDP src dst 01:80:c2:00:00:0e --> write group 0x02000000 > 1 60 6 lport 2 vlan 2 IPv6 src dst --> write group 0x02000000 > 1 60 174 lport 1 vlan 1 LLDP src dst 01:80:c2:00:00:0e --> write group 0x01000000 > 1 60 174 lport 2 vlan 2 IP src dst --> write group 0x02000000 > 1 60 6 lport 1 vlan 1 IPv6 src dst --> write group 0x01000000 > 1 60 181 lport 2 vlan 2 ARP src dst --> write group 0x02000000 > 1 10 715 lport 2 --> apply new vlan 2 goto tbl 20 > 1 60 177 lport 1 vlan 1 ARP src dst --> write group 0x01000000 > 1 60 174 lport 1 vlan 1 IP src dst --> write group 0x01000000 > 1 10 717 lport 1 --> apply new vlan 1 goto tbl 20 > 1 0 1432 lport 0(0xffff) --> goto tbl 10 > > (qemu) info rocker-of-dpa-groups sw1 > id (decode) --> buckets > 0x32000001 (type L2 multicast vlan 2 index 1) --> groups [0x02000001,0x02000000] > 0x02000001 (type L2 interface vlan 2 lport 1) --> pop vlan out lport 1 > 0x01000002 (type L2 interface vlan 1 lport 2) --> pop vlan out lport 2 > 0x02000000 (type L2 interface vlan 2 lport 0) --> pop vlan out lport 0 > 0x01000000 (type L2 interface vlan 1 lport 0) --> pop vlan out lport 0 > 0x31000000 (type L2 multicast vlan 1 index 0) --> groups [0x01000002,0x01000000] > > Signed-off-by: Scott Feldman > Signed-off-by: Jiri Pirko > --- > hmp-commands.hx | 24 ++++ > hmp.c | 303 ++++++++++++++++++++++++++++++++++++++++ > hmp.h | 4 + > hw/net/rocker/rocker.c | 45 ++++++ > hw/net/rocker/rocker_fp.c | 10 ++ > hw/net/rocker/rocker_fp.h | 1 + > hw/net/rocker/rocker_of_dpa.c | 308 +++++++++++++++++++++++++++++++++++++++++ > monitor.c | 28 ++++ > qapi-schema.json | 3 + > qapi/rocker.json | 259 ++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 97 +++++++++++++ > 11 files changed, 1082 insertions(+) > create mode 100644 qapi/rocker.json I don't object this method but not sure it was worth (especially consider it needs nearly a thousand lines of codes). Could we just do this through remote controller or agent? Thanks