From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC4zA-0005bv-Q8 for qemu-devel@nongnu.org; Fri, 16 Jan 2015 06:22:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YC4z6-0006kj-Nv for qemu-devel@nongnu.org; Fri, 16 Jan 2015 06:22:40 -0500 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:55294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC4z6-0006jy-Fk for qemu-devel@nongnu.org; Fri, 16 Jan 2015 06:22:36 -0500 Received: by mail-wg0-f45.google.com with SMTP id y19so20008846wgg.4 for ; Fri, 16 Jan 2015 03:22:35 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54B8F475.8070007@redhat.com> Date: Fri, 16 Jan 2015 12:22:29 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1421171537-19118-1-git-send-email-pbonzini@redhat.com> <1421171537-19118-4-git-send-email-pbonzini@redhat.com> <20150116020439.GD3079@ad.nay.redhat.com> In-Reply-To: <20150116020439.GD3079@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/8] rcu: add rcutorture List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com On 16/01/2015 03:04, Fam Zheng wrote: > On Tue, 01/13 18:52, Paolo Bonzini wrote: >> +int main(int argc, char *argv[]) >> +{ >> + int nreaders = 1; >> + int duration = 1; >> + >> + if (argc >= 2 && argv[1][0] == '-') { >> + g_test_init(&argc, &argv, NULL); >> + g_test_add_func("/rcu/torture/short/1reader", gtest_stress_1_1); >> + g_test_add_func("/rcu/torture/short/10readers", gtest_stress_10_1); >> + g_test_add_func("/rcu/torture/long/1reader", gtest_stress_1_5); >> + g_test_add_func("/rcu/torture/long/10readers", gtest_stress_10_5); > > Why do we need short tests when we have long tests? What are different other > than the durations? Nothing really. I guess long tests could be made optional (-m slow). >> + return g_test_run(); >> + } >> + >> + if (argc >= 2) { >> + nreaders = strtoul(argv[1], NULL, 0); >> + } >> + if (argc > 3) { >> + duration = strtoul(argv[3], NULL, 0); >> + } >> + if (argc < 3 || strcmp(argv[2], "stress") == 0) { >> + stresstest(nreaders, duration); >> + } else if (strcmp(argv[2], "rperf") == 0) { >> + rperftest(nreaders, duration); >> + } else if (strcmp(argv[2], "uperf") == 0) { >> + uperftest(nreaders, duration); >> + } else if (strcmp(argv[2], "perf") == 0) { >> + perftest(nreaders, duration); >> + } >> + usage(argc, argv); >> + return 0; >> +} >> diff --git a/util/rcu.c b/util/rcu.c >> index f8f52ae..8df16d9 100644 >> --- a/util/rcu.c >> +++ b/util/rcu.c >> @@ -169,5 +169,4 @@ static void __attribute__((__constructor__)) rcu_init(void) >> { >> qemu_mutex_init(&rcu_gp_lock); >> qemu_event_init(&rcu_gp_event, true); >> - rcu_register_thread(); > > Maybe don't add this line in patch 2? More like don't remove it in patch 3. ;) Paolo