From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCB4r-00036e-SI for qemu-devel@nongnu.org; Fri, 16 Jan 2015 12:52:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YCB4m-0005mb-Q1 for qemu-devel@nongnu.org; Fri, 16 Jan 2015 12:52:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCB4m-0005mX-IQ for qemu-devel@nongnu.org; Fri, 16 Jan 2015 12:52:52 -0500 Message-ID: <54B94FF1.3090908@redhat.com> Date: Fri, 16 Jan 2015 12:52:49 -0500 From: Max Reitz MIME-Version: 1.0 References: <1421080265-2228-1-git-send-email-jsnow@redhat.com> <1421080265-2228-10-git-send-email-jsnow@redhat.com> In-Reply-To: <1421080265-2228-10-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v11 09/13] qmp: Add support of "dirty-bitmap" sync mode for drive-backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com On 2015-01-12 at 11:31, John Snow wrote: > For "dirty-bitmap" sync mode, the block job will iterate through the > given dirty bitmap to decide if a sector needs backup (backup all the > dirty clusters and skip clean ones), just as allocation conditions of > "top" sync mode. > > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > --- > block.c | 5 ++ > block/backup.c | 120 ++++++++++++++++++++++++++++++++++++++-------- > block/mirror.c | 4 ++ > blockdev.c | 14 +++++- > hmp.c | 3 +- > include/block/block.h | 1 + > include/block/block_int.h | 2 + > qapi/block-core.json | 11 +++-- > qmp-commands.hx | 7 +-- > 9 files changed, 137 insertions(+), 30 deletions(-) Since you seem to be intending to rethink the "frozen" state, I'm just scanning through the series from patch 8 on. While this patch doesn't seem to have changed much conceptually since the last version I reviewed, with it applied to master, qemu fails to build due to Fam's blockdev-backup series (some new calls to backup_start() which have to be adapted). Max