From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCBzS-0005Je-E0 for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:51:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YCBzO-0007BY-9a for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:51:26 -0500 Received: from mail-qa0-x22d.google.com ([2607:f8b0:400d:c00::22d]:57154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCBzO-0007BR-5u for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:51:22 -0500 Received: by mail-qa0-f45.google.com with SMTP id n8so16666482qaq.4 for ; Fri, 16 Jan 2015 10:51:21 -0800 (PST) Sender: Richard Henderson Message-ID: <54B95DA6.1040906@twiddle.net> Date: Fri, 16 Jan 2015 10:51:18 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1421432008-6786-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1421432008-6786-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cpu_ldst.h: Don't define helpers if MMU_MODE*_SUFFIX not defined List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Paolo Bonzini , patches@linaro.org On 01/16/2015 10:13 AM, Peter Maydell wrote: > Not all targets define a full set of suffix strings for the > NB_MMU_MODES that they have. In this situation, don't define any > helper functions for that mode, rather than defining helper functions > with no suffix at all. The MMU mode is still functional; it is merely > not directly accessible via cpu_ld*_MODE from target helper functions. > > Also add an "NB_MMU_MODES >= 2" check to the definition of the mode 1 > helpers -- some targets only define one MMU mode. > > Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson r~