From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCC03-0006C5-Hv for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:52:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YCBzx-0007JL-As for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:52:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCBzx-0007JG-3K for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:51:57 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0GIptcO020925 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 16 Jan 2015 13:51:55 -0500 Message-ID: <54B95DC9.8030606@redhat.com> Date: Fri, 16 Jan 2015 13:51:53 -0500 From: John Snow MIME-Version: 1.0 References: <1421372322-17829-1-git-send-email-famz@redhat.com> <20150116132319.GA32469@stefanha-thinkpad.redhat.com> In-Reply-To: <20150116132319.GA32469@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qemu-iotests: Fix supported_oses check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org On 01/16/2015 08:23 AM, Stefan Hajnoczi wrote: > On Fri, Jan 16, 2015 at 09:38:42AM +0800, Fam Zheng wrote: >> There is a bug in the recently added sys.platform test, and we no longer >> run python tests, because "linux2" is the value to compare here. So do a >> prefix match. According to python doc [1], the way to use sys.platform >> is "unless you want to test for a specific system version, it is >> therefore recommended to use the following idiom": >> >> if sys.platform.startswith('freebsd'): >> # FreeBSD-specific code here... >> elif sys.platform.startswith('linux'): >> # Linux-specific code here... >> >> [1]: https://docs.python.org/2.7/library/sys.html#sys.platform >> >> Signed-off-by: Fam Zheng >> >> --- >> v2: Don't use any(). >> Explain why prefix match is fine. >> (Thanks, Stefan) >> --- >> tests/qemu-iotests/iotests.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks, applied to my block tree: > https://github.com/stefanha/qemu/commits/block > > Stefan > Thanks for this! fake_internet_karma++