qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] net: synchronize net_host_device_remove with host_net_remove_completion
Date: Mon, 19 Jan 2015 12:27:11 +0100	[thread overview]
Message-ID: <54BCEA0F.8070707@redhat.com> (raw)
In-Reply-To: <54A6C53E.3050905@redhat.com>



On 02/01/2015 17:20, Paolo Bonzini wrote:
>> > 
>> > The assert can be dropped completely since the code already has an
>> > equivalent assert:
>> > 
>> >   queues = qemu_find_net_clients_except(nc->name, ncs,
>> >                                         NET_CLIENT_OPTIONS_KIND_NIC,
>> >                                         MAX_QUEUE_NUM);
>> >   assert(queues != 0); <-- fail if type == NET_CLIENT_OPTIONS_KIND_NIC
> I left it on purpose for documentation, but I'll send v2 next week that
> removes it.

Actually it's not the same.  If you have "-netdev user,id=e1000 -device
e1000,netdev=e1000" you will be able to call qemu_del_net_client on the
NIC, and it will _not_ fail if the assertion is removed.

Paolo

  reply	other threads:[~2015-01-19 11:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-23 16:53 [Qemu-devel] [PATCH] net: synchronize net_host_device_remove with host_net_remove_completion Paolo Bonzini
2015-01-02 14:06 ` Stefan Hajnoczi
2015-01-02 16:20   ` Paolo Bonzini
2015-01-19 11:27     ` Paolo Bonzini [this message]
2015-01-28  9:50       ` Paolo Bonzini
2015-02-06 13:54       ` Stefan Hajnoczi
2015-02-06 14:46         ` Paolo Bonzini
2015-02-06 16:51           ` Stefan Hajnoczi
2015-01-29 10:15 ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BCEA0F.8070707@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).