From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDAtw-0007oX-QG for qemu-devel@nongnu.org; Mon, 19 Jan 2015 06:53:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDAtr-00070E-RL for qemu-devel@nongnu.org; Mon, 19 Jan 2015 06:53:48 -0500 Received: from mail-we0-x22b.google.com ([2a00:1450:400c:c03::22b]:64912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDAtr-000709-KK for qemu-devel@nongnu.org; Mon, 19 Jan 2015 06:53:43 -0500 Received: by mail-we0-f171.google.com with SMTP id u56so31005355wes.2 for ; Mon, 19 Jan 2015 03:53:43 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54BCF041.1030706@redhat.com> Date: Mon, 19 Jan 2015 12:53:37 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150112115944.3504.66763.stgit@PASHA-ISP> <20150112120146.3504.82181.stgit@PASHA-ISP> <54B3BD30.9080407@redhat.com> <43535.7048445896$1421393030@news.gmane.org> In-Reply-To: <43535.7048445896$1421393030@news.gmane.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v7 21/21] replay: recording of the user input List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, alex.bennee@linaro.org, afaerber@suse.de, fred.konrad@greensocs.com On 16/01/2015 08:23, Pavel Dovgaluk wrote: >> > >> > Similar to other cases, please wrap this into a single function, >> > something like >> > >> > if (replay_handle_input_event(evt)) { >> > return; >> > } >> > >> > /* ... original contents of qemu_input_event_send ... */ > I can wrap this, but cannot get rid of _impl function. > In replay mode we have to make two things: > - Deny real user imput (qemu_input_event_send should do nothing) > - Read input from the log (qemu_input_event_send should process read data) That's fine. Paolo