From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDB2y-00045m-B1 for qemu-devel@nongnu.org; Mon, 19 Jan 2015 07:03:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDB2u-0002AM-B6 for qemu-devel@nongnu.org; Mon, 19 Jan 2015 07:03:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDB2u-000296-4Z for qemu-devel@nongnu.org; Mon, 19 Jan 2015 07:03:04 -0500 Message-ID: <54BCF261.8000104@redhat.com> Date: Mon, 19 Jan 2015 13:02:41 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1421321204-17764-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1421321204-17764-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] multiboot: Fix offset of bootloader name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: sir@cmpwn.com, stefanha@redhat.com, mreitz@redhat.com On 15/01/2015 12:26, Kevin Wolf wrote: > This fixes a recent Multiboot load regression (see patch 2) that we > noticed while hacking on the advent calendar image for December 24. > > Kevin Wolf (3): > tests/multiboot: Update reference output > multiboot: Fix offset of bootloader name > tests/multiboot: Add test for modules > > hw/i386/multiboot.c | 16 +++++++------ > tests/multiboot/Makefile | 5 ++++- > tests/multiboot/libc.c | 12 ++++++++++ > tests/multiboot/libc.h | 1 + > tests/multiboot/mmap.out | 37 +++++++++++++++--------------- > tests/multiboot/module.txt | 1 + > tests/multiboot/modules.c | 55 +++++++++++++++++++++++++++++++++++++++++++++ > tests/multiboot/modules.out | 38 +++++++++++++++++++++++++++++++ > tests/multiboot/run_test.sh | 9 +++++++- > 9 files changed, 146 insertions(+), 28 deletions(-) > create mode 100644 tests/multiboot/module.txt > create mode 100644 tests/multiboot/modules.c > create mode 100644 tests/multiboot/modules.out > Thanks, I'll put this in the next pull request. Paolo