From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
alex.bennee@linaro.org, mark.burton@greensocs.com,
real@ispras.ru, batuzovk@ispras.ru,
maria.klimushenkova@ispras.ru, afaerber@suse.de,
fred.konrad@greensocs.com
Subject: Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying clock ticks
Date: Mon, 19 Jan 2015 13:15:25 +0100 [thread overview]
Message-ID: <54BCF55D.7040607@redhat.com> (raw)
In-Reply-To: <000c01d033df$ece29420$c6a7bc60$@Dovgaluk@ispras.ru>
On 19/01/2015 13:03, Pavel Dovgaluk wrote:
> It will work for protecting the events list (I've already did this).
> But that will not work for protecting the log file.
> replay_run_event can write some data to the log. And also some other function like replay_checkpoint
> can also write to the log simultaneously (if we will remove the global mutex).
> That's why we cannot simply replace the global mutex with some kind of local one.
That's why you have to document very well the architecture and the
locking policy. For example, why can't replay_run_event (or something
that it calls) take the replay lock locally, when it writes to the log?
If you do not document the architecture, we run in circles with me
asking possibly stupid questions and you thinking that my questions are
stupid. :)
Paolo
next prev parent reply other threads:[~2015-01-19 12:16 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 11:59 [Qemu-devel] [RFC PATCH v7 00/21] Deterministic replay core Pavel Dovgalyuk
2015-01-12 11:59 ` [Qemu-devel] [RFC PATCH v7 01/21] i386: partial revert of interrupt poll fix Pavel Dovgalyuk
2015-01-12 11:59 ` [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs Pavel Dovgalyuk
2015-01-12 12:19 ` Paolo Bonzini
2015-01-12 12:21 ` Pavel Dovgaluk
2015-01-12 12:25 ` Paolo Bonzini
2015-01-20 17:07 ` Eric Blake
2015-01-12 12:00 ` [Qemu-devel] [RFC PATCH v7 03/21] sysemu: system functions for replay Pavel Dovgalyuk
2015-01-12 12:00 ` [Qemu-devel] [RFC PATCH v7 04/21] replay: internal functions for replay log Pavel Dovgalyuk
2015-01-12 12:49 ` Paolo Bonzini
2015-01-12 12:52 ` Pavel Dovgaluk
2015-01-12 12:00 ` [Qemu-devel] [RFC PATCH v7 05/21] replay: introduce icount event Pavel Dovgalyuk
2015-01-12 12:00 ` [Qemu-devel] [RFC PATCH v7 06/21] cpu-exec: allow temporary disabling icount Pavel Dovgalyuk
2015-01-12 12:00 ` [Qemu-devel] [RFC PATCH v7 07/21] cpu: replay instructions sequence Pavel Dovgalyuk
2015-01-12 12:00 ` [Qemu-devel] [RFC PATCH v7 08/21] replay: interrupts and exceptions Pavel Dovgalyuk
2015-01-12 12:34 ` Paolo Bonzini
2015-01-12 12:40 ` Pavel Dovgaluk
2015-01-12 12:54 ` Paolo Bonzini
2015-01-14 9:07 ` Pavel Dovgaluk
[not found] ` <3141.42739302969$1421226482@news.gmane.org>
2015-01-14 9:49 ` Paolo Bonzini
2015-01-14 10:06 ` Pavel Dovgaluk
[not found] ` <48665.1020743468$1421230035@news.gmane.org>
2015-01-14 10:21 ` Paolo Bonzini
2015-01-12 12:00 ` [Qemu-devel] [RFC PATCH v7 09/21] replay: asynchronous events infrastructure Pavel Dovgalyuk
2015-01-12 12:20 ` Paolo Bonzini
2015-01-12 12:00 ` [Qemu-devel] [RFC PATCH v7 10/21] cpus: make icount warp deterministic in replay mode Pavel Dovgalyuk
2015-01-12 12:01 ` Paolo Bonzini
2015-01-12 12:00 ` [Qemu-devel] [RFC PATCH v7 11/21] timer: fix usage of clock functions Pavel Dovgalyuk
2015-01-12 12:03 ` Paolo Bonzini
2015-01-12 12:00 ` [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying clock ticks Pavel Dovgalyuk
2015-01-12 12:14 ` Paolo Bonzini
2015-01-12 12:43 ` Pavel Dovgaluk
2015-01-12 12:45 ` Paolo Bonzini
2015-01-13 9:21 ` Pavel Dovgaluk
2015-01-13 9:38 ` Paolo Bonzini
2015-01-16 8:03 ` Pavel Dovgaluk
2015-01-19 11:51 ` Paolo Bonzini
2015-01-19 12:03 ` Pavel Dovgaluk
2015-01-19 12:15 ` Paolo Bonzini [this message]
2015-01-19 12:43 ` Pavel Dovgaluk
2015-01-19 12:57 ` Paolo Bonzini
2015-01-19 13:01 ` Pavel Dovgaluk
2015-01-19 13:02 ` Paolo Bonzini
2015-01-19 13:10 ` Pavel Dovgaluk
2015-01-19 13:12 ` Paolo Bonzini
2015-01-20 6:24 ` Pavel Dovgaluk
2015-01-12 12:01 ` [Qemu-devel] [RFC PATCH v7 13/21] replay: recording and replaying different timers Pavel Dovgalyuk
2015-01-12 12:08 ` Paolo Bonzini
2015-01-12 12:01 ` [Qemu-devel] [RFC PATCH v7 14/21] replay: shutdown event Pavel Dovgalyuk
2015-01-12 12:05 ` Paolo Bonzini
2015-01-12 12:01 ` [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints Pavel Dovgalyuk
2015-01-12 12:13 ` Paolo Bonzini
2015-01-13 9:07 ` Pavel Dovgaluk
2015-01-13 9:15 ` Pavel Dovgaluk
2015-01-13 9:40 ` Paolo Bonzini
2015-01-13 14:26 ` Pavel Dovgaluk
[not found] ` <37329.9191626304$1421159249@news.gmane.org>
2015-01-13 14:52 ` Paolo Bonzini
2015-01-13 14:53 ` Paolo Bonzini
2015-01-22 8:50 ` Pavel Dovgaluk
2015-01-12 12:01 ` [Qemu-devel] [RFC PATCH v7 16/21] replay: bottom halves Pavel Dovgalyuk
2015-01-12 12:16 ` Paolo Bonzini
2015-01-12 12:01 ` [Qemu-devel] [RFC PATCH v7 17/21] replay: replay aio requests Pavel Dovgalyuk
2015-01-12 12:01 ` [Qemu-devel] [RFC PATCH v7 18/21] replay: thread pool Pavel Dovgalyuk
2015-01-12 12:01 ` [Qemu-devel] [RFC PATCH v7 19/21] replay: initialization and deinitialization Pavel Dovgalyuk
2015-01-12 12:01 ` [Qemu-devel] [RFC PATCH v7 20/21] replay: command line options Pavel Dovgalyuk
2015-01-12 12:21 ` Paolo Bonzini
2015-01-12 12:23 ` Pavel Dovgaluk
2015-01-12 12:26 ` Paolo Bonzini
2015-01-12 12:01 ` [Qemu-devel] [RFC PATCH v7 21/21] replay: recording of the user input Pavel Dovgalyuk
2015-01-12 12:25 ` Paolo Bonzini
2015-01-16 7:23 ` Pavel Dovgaluk
[not found] ` <43535.7048445896$1421393030@news.gmane.org>
2015-01-19 11:53 ` Paolo Bonzini
2015-01-12 12:39 ` [Qemu-devel] [RFC PATCH v7 00/21] Deterministic replay core Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BCF55D.7040607@redhat.com \
--to=pbonzini@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=afaerber@suse.de \
--cc=alex.bennee@linaro.org \
--cc=batuzovk@ispras.ru \
--cc=fred.konrad@greensocs.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mark.burton@greensocs.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=real@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).