From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDESO-0000yE-I6 for qemu-devel@nongnu.org; Mon, 19 Jan 2015 10:41:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDESL-0005f3-Ai for qemu-devel@nongnu.org; Mon, 19 Jan 2015 10:41:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDESL-0005eu-0z for qemu-devel@nongnu.org; Mon, 19 Jan 2015 10:41:33 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0JFfV0E023507 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 19 Jan 2015 10:41:32 -0500 Message-ID: <54BD25A6.9010502@redhat.com> Date: Mon, 19 Jan 2015 16:41:26 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1419437261-21113-1-git-send-email-pbonzini@redhat.com> <1419437261-21113-2-git-send-email-pbonzini@redhat.com> <20150119161549.0a4162f3@nial.brq.redhat.com> In-Reply-To: <20150119161549.0a4162f3@nial.brq.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 1/4] pc: append ssdt-misc.dsl to the DSDT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: mst@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com On 19/01/2015 16:15, Igor Mammedov wrote: > On Wed, 24 Dec 2014 17:07:35 +0100 > Paolo Bonzini wrote: > >> This part of the ACPI tables can vary in size across machine types, but > s/machine types/QEMU versions/ since it doesn't change its size on machine > type. Right. >> does not depend on the command-line. It is an SSDT just because it is > s/does not/its size does not/ Right. >> the same for i440fx and Q35, and making it an SSDT made the code a bit > it's in SSDT because we are patching its values and DSDT were supposed > to stay static (not only size but contents also). > I'd prefer to keep dynamic part in SSDT to maintain the same separation > for now. The DSDT is being patched anyway for the SMC. So "the DSDT is dynamic, the SSDT is static" is not something that happens anyway. The truth is "the SSDT (apart from ssdt-misc) defines Devices each of which comes from a template". This patch removes the "apart from ssdt-misc" part, and also moves the patching of the SMC out of the per-machine-type AML, since it is shared anyway. >> simpler. However, it also complicates backwards compatibility, so >> merge it with the DSDT. > What are these complications? The complication arises if we want to make the SSDT exactly the same for all QEMU versions, given a (machine type, command line) pair. Then you either cannot do any change to ssdt-misc, or you have to keep different copies for each machine type. Paolo