From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDF19-0004Pz-8p for qemu-devel@nongnu.org; Mon, 19 Jan 2015 11:17:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDF15-00035g-6v for qemu-devel@nongnu.org; Mon, 19 Jan 2015 11:17:31 -0500 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:49182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDF15-00035b-0m for qemu-devel@nongnu.org; Mon, 19 Jan 2015 11:17:27 -0500 Received: by mail-wi0-f175.google.com with SMTP id fb4so10414798wid.2 for ; Mon, 19 Jan 2015 08:17:26 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54BD2E12.5080707@redhat.com> Date: Mon, 19 Jan 2015 17:17:22 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1421679429-9047-1-git-send-email-jwhite@codeweavers.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] Bug fix: delete the reader entry after queueing an event, not before. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Jeremy White Cc: qemu-devel@nongnu.org, Gerd Hoffmann On 19/01/2015 16:42, Marc-André Lureau wrote: > On Mon, Jan 19, 2015 at 3:57 PM, Jeremy White wrote: >> As far as I can tell, the vreader_remove_reader function is not presently in >> use anywhere; I have an upcoming patch set that uses it. >> >> Signed-off-by: Jeremy White >> --- >> libcacard/vreader.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libcacard/vreader.c b/libcacard/vreader.c >> index 0315dd8..8b10d6a 100644 >> --- a/libcacard/vreader.c >> +++ b/libcacard/vreader.c >> @@ -529,8 +529,8 @@ vreader_remove_reader(VReader *reader) >> } >> vreader_dequeue(vreader_list, current_entry); >> vreader_list_unlock(); >> - vreader_list_entry_delete(current_entry); >> vevent_queue_vevent(vevent_new(VEVENT_READER_REMOVE, reader, NULL)); >> + vreader_list_entry_delete(current_entry); >> return VREADER_OK; >> } >> >> -- >> 1.7.10.4 >> >> > > Reviewed-by: Marc-André Lureau Gerd, are you maintaining libcacard nowadays? If so, can you add an entry to MAINTAINERS? (And if not, perhaps Marc-André could maintain it...) Paolo