[Qemu-devel] [PATCH] target-tricore: Add missing ULL suffix on 64 bit constant

[Qemu-devel] [PATCH] target-tricore: Add missing ULL suffix on 64 bit constant

[Peter Maydell]

Add a missing ULL suffix to a 64 bit constant: this suppresses a
compiler warning from mingw32 gcc.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-tricore/op_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c
index 13e2729..5704549 100644
--- a/target-tricore/op_helper.c
+++ b/target-tricore/op_helper.c
@@ -994,7 +994,7 @@ uint32_t helper_sha(CPUTriCoreState *env, target_ulong r1, target_ulong r2)
     } else if (shift_count > 0) {
         result = t1 << shift_count;
         /* calc carry */
-        env->PSW_USB_C = ((result & 0xffffffff00000000) != 0);
+        env->PSW_USB_C = ((result & 0xffffffff00000000ULL) != 0);
         /* calc v */
         env->PSW_USB_V = (((result > 0x7fffffffLL) ||
                            (result < -0x80000000LL)) << 31);
-- 
1.9.1

Re: [Qemu-devel] [PATCH] target-tricore: Add missing ULL suffix on 64 bit constant

[Bastian Koppelmann]

On 12/23/2014 10:24 PM, Peter Maydell wrote:
> Add a missing ULL suffix to a 64 bit constant: this suppresses a
> compiler warning from mingw32 gcc.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   target-tricore/op_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks, applied it to my tricore-next  branch.

Cheers,
Bastian

Re: [Qemu-devel] [PATCH] target-tricore: Add missing ULL suffix on 64 bit constant

[Peter Maydell]

On 24 December 2014 at 00:03, Bastian Koppelmann
<kbastian@mail.uni-paderborn.de> wrote:
>
> On 12/23/2014 10:24 PM, Peter Maydell wrote:
>>
>> Add a missing ULL suffix to a 64 bit constant: this suppresses a
>> compiler warning from mingw32 gcc.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>>   target-tricore/op_helper.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> Thanks, applied it to my tricore-next  branch.

Ping?

(I'm putting together a "miscellaneous stuff from me that's
got forgotten" pull, so I could put it in that if you don't
have any other tricore stuff queued and don't want to do a
pullreq for a one line fix.)

-- PMM

Re: [Qemu-devel] [PATCH] target-tricore: Add missing ULL suffix on 64 bit constant

[Bastian Koppelmann]

On 01/19/2015 03:21 PM, Peter Maydell wrote:
> On 24 December 2014 at 00:03, Bastian Koppelmann
> <kbastian@mail.uni-paderborn.de> wrote:
>> On 12/23/2014 10:24 PM, Peter Maydell wrote:
>>> Add a missing ULL suffix to a 64 bit constant: this suppresses a
>>> compiler warning from mingw32 gcc.
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>> ---
>>>    target-tricore/op_helper.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>> Thanks, applied it to my tricore-next  branch.
> Ping?
Hi Peter,
> (I'm putting together a "miscellaneous stuff from me that's
> got forgotten" pull, so I could put it in that if you don't
> have any other tricore stuff queued and don't want to do a
> pullreq for a one line fix.)
thanks for the effort, but it is not forgotten. I'm still working on a 
patchset for the next pullreq. I'm sending the patchset to the list this 
week and depending on Richards feedback I will send a pullreq this or 
next week , but it is hard to tell. If this is too long for you, feel 
free to add your patch to the misc pull.

Cheers,
Bastian
> -- PMM