From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDFf7-0003At-Rc for qemu-devel@nongnu.org; Mon, 19 Jan 2015 11:58:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDFf4-0002wC-Lf for qemu-devel@nongnu.org; Mon, 19 Jan 2015 11:58:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDFf4-0002w6-84 for qemu-devel@nongnu.org; Mon, 19 Jan 2015 11:58:46 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0JGwhFE000339 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 19 Jan 2015 11:58:43 -0500 Message-ID: <54BD37C2.6080706@redhat.com> Date: Mon, 19 Jan 2015 11:58:42 -0500 From: John Snow MIME-Version: 1.0 References: <1421686238-8103-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1421686238-8103-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] bios-tables-test: split piix4 and q35 tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: mst@redhat.com On 01/19/2015 11:50 AM, Paolo Bonzini wrote: > This makes it clear which one is failing. > > Signed-off-by: Paolo Bonzini > --- > tests/bios-tables-test.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 2519f7d..4d0fa84 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -765,7 +765,7 @@ static void test_acpi_one(const char *params, test_data *data) > g_free(args); > } > > -static void test_acpi_tcg(void) > +static void test_acpi_piix4_tcg(void) > { > test_data data; > > @@ -776,6 +776,11 @@ static void test_acpi_tcg(void) > data.machine = MACHINE_PC; > test_acpi_one("-machine accel=tcg", &data); > free_test_data(&data); > +} > + > +static void test_acpi_q35_tcg(void) > +{ > + test_data data; > > memset(&data, 0, sizeof(data)); > data.machine = MACHINE_Q35; > @@ -799,7 +804,8 @@ int main(int argc, char *argv[]) > g_test_init(&argc, &argv, NULL); > > if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) { > - qtest_add_func("acpi/tcg", test_acpi_tcg); > + qtest_add_func("acpi/piix4/tcg", test_acpi_piix4_tcg); > + qtest_add_func("acpi/q35/tcg", test_acpi_q35_tcg); > } > ret = g_test_run(); > unlink(disk); > Reviewed-by: John Snow