From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46561)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YDFjo-0001rZ-Ex
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:03:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YDFjl-0004n3-A4
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:03:40 -0500
Received: from mail-wg0-x22c.google.com ([2a00:1450:400c:c00::22c]:59465)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YDFjl-0004mw-3J
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:03:37 -0500
Received: by mail-wg0-f44.google.com with SMTP id y19so32853310wgg.3
	for <qemu-devel@nongnu.org>; Mon, 19 Jan 2015 09:03:36 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <54BD38E4.5010507@redhat.com>
Date: Mon, 19 Jan 2015 18:03:32 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1421120079-987-1-git-send-email-jsnow@redhat.com>
	<1421120079-987-7-git-send-email-jsnow@redhat.com>
In-Reply-To: <1421120079-987-7-git-send-email-jsnow@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/14] libqos: add pc specific interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, marc.mari.barcelo@gmail.com, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com



On 13/01/2015 04:34, John Snow wrote:
> +typedef struct QOSOperations {
> +    QGuestAllocator *(*init_allocator)(QAllocOpts);
> +    void (*uninit_allocator)(QGuestAllocator *);
> +} QOSOperations;

Typically called FooOps or FooInfo.  Apart from that,

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>