From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDGOW-00084Y-Vw for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:45:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDGOS-00032B-T2 for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:45:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDGOS-0002zE-L7 for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:45:40 -0500 Message-ID: <54BD42BD.4060201@redhat.com> Date: Mon, 19 Jan 2015 10:45:33 -0700 From: Eric Blake MIME-Version: 1.0 References: <71BB46AD-4E5B-4876-84F0-12260D6846D3@gmail.com> <3581523B-8162-4CB7-9B21-DFA980E15F97@gmail.com> <87egqvt9rh.fsf@blackfin.pond.sub.org> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ofgugADjetWN7g60X62gUUm36mPGvsVXu" Subject: Re: [Qemu-devel] [PATCH v7] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid , Markus Armbruster Cc: Peter Maydell , qemu-devel qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ofgugADjetWN7g60X62gUUm36mPGvsVXu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/19/2015 09:32 AM, Programmingkid wrote: >=20 > On Jan 16, 2015, at 3:22 AM, Markus Armbruster wrote: >=20 >> Programmingkid writes: >> >>> This patch allows Mac OS X to use a real CDROM disc in QEMU. Testing = this patch will require using QEMU v2.2.0 because the current git version= has a bug in it that prevents /dev/cdrom from being used. "make check" d= id pass and my Debian boot disc did work.=20 >>> >>> Signed-off-by: John Arbuckle >> >> Subject line is too long, and the body lacks line breaks. Suggest >> something like: >> >> block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD >=20 > Unfortunately I can't change the subject line after posting the first v= ersion of the patch. Others have to know the history of this patch. I wil= l try to include the file name in the future.=20 Yes, you can. It's a bit trickier, in that you'll probably want to include a mailing list archive link in v8 and explicitly point out that the subject has changed, as well as a followup to v7 that points to the list archive of v8 to help people find the changed name. But there is nothing technically stopping you from renaming a patch to something more appropriate. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ofgugADjetWN7g60X62gUUm36mPGvsVXu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUvUK9AAoJEKeha0olJ0NqAK4H/AgOhOGodXeK2OTmxgsg5P6o L54uTk+ZxtujFL+YACY3qWTwdbkyjvgGoKYx6ABtNTYbHPztK1dz8oqhijwHP+J1 d4r5yOUsdfydSEIl2tuXD+hF+554qXFcERlmgU59OB6rVYmMx//glcQZlMpYLaiI OD/A/eWRkkn8bdXSlvakTmGVmROnOa3h/pYagog7XovlfFFVrvBiP+6ygifa5Rbo x9eGVKqCk86i8BiYoEuIFGTGhMbgIgdzRuihYWRSiUuSrE2q5RUAX+14k9UeNTg3 1sFXcg9HHr/83ikXyk7nj+mim6IjXUBqGUpBrvHl5SM1twUPiOB0Cj02tjYyImY= =Xc2f -----END PGP SIGNATURE----- --ofgugADjetWN7g60X62gUUm36mPGvsVXu--