From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDGpf-0003Qi-5a for qemu-devel@nongnu.org; Mon, 19 Jan 2015 13:13:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDGpa-0004Vb-0L for qemu-devel@nongnu.org; Mon, 19 Jan 2015 13:13:47 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52192 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDGpZ-0004VP-Pr for qemu-devel@nongnu.org; Mon, 19 Jan 2015 13:13:41 -0500 Message-ID: <54BD4953.2040109@suse.de> Date: Mon, 19 Jan 2015 19:13:39 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1421666643-8092-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1421666643-8092-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] pc: fix KVM features in pc-1.3 and earlier machine types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, ehabkost@redhat.com Am 19.01.2015 um 12:24 schrieb Paolo Bonzini: > Due to a typo, instead of disabling KVM_FEATURE_PV_EOI (bit > 6) these machine types are disabling bits 1 and 2, which are > KVM_FEATURE_NOP_IO_DELAY and KVM_FEATURE_MMU_OP. Not a big deal > because they aren't very important and KVM_FEATURE_MMU_OP is > disabled anyway. The worst part is actually that KVM_FEATURE_PV_EOI > is remaining enabled. >=20 > Signed-off-by: Paolo Bonzini > --- > hw/i386/pc_piix.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index f0a3201..97a754e 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -406,7 +406,7 @@ static void pc_compat_1_3(MachineState *machine) > static void pc_compat_1_2(MachineState *machine) > { > pc_compat_1_3(machine); > - x86_cpu_compat_kvm_no_autoenable(FEAT_KVM, KVM_FEATURE_PV_EOI); > + x86_cpu_compat_kvm_no_autoenable(FEAT_KVM, 1 << KVM_FEATURE_PV_EOI= ); > } > =20 > static void pc_init_pci_2_2(MachineState *machine) > @@ -483,7 +483,7 @@ static void pc_init_isa(MachineState *machine) > if (!machine->cpu_model) { > machine->cpu_model =3D "486"; > } > - x86_cpu_compat_kvm_no_autoenable(FEAT_KVM, KVM_FEATURE_PV_EOI); > + x86_cpu_compat_kvm_no_autoenable(FEAT_KVM, 1 << KVM_FEATURE_PV_EOI= ); > enable_compat_apic_id_mode(); > pc_init1(machine, 0, 1); > } Might it make sense to tweak that helper function instead to avoid this reoccurring? Either way, no objection, please apply through kvm queue. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)