From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YDI2P-0003NG-1f
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 14:31:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YDI2L-0005zQ-RR
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 14:31:00 -0500
Received: from mail-qc0-x22c.google.com ([2607:f8b0:400d:c01::22c]:47769)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YDI2L-0005zI-NP
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 14:30:57 -0500
Received: by mail-qc0-f172.google.com with SMTP id i8so18845531qcq.3
	for <qemu-devel@nongnu.org>; Mon, 19 Jan 2015 11:30:57 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <54BD5B6B.6090708@twiddle.net>
Date: Mon, 19 Jan 2015 11:30:51 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1413910544-20150-1-git-send-email-greg.bellows@linaro.org>
	<1413910544-20150-6-git-send-email-greg.bellows@linaro.org>
	<CAFEAcA84+u-bdtSX+=m-FH2oSdoqostSVW5Zr73O3UPnNNuU4Q@mail.gmail.com>
	<CAFEAcA-c1OXi-DreK2wzi8mhRT_RTYkGPDGy7pJpoTya=RQnUA@mail.gmail.com>
	<54BD426A.5070107@twiddle.net>
	<CAFEAcA-mBVxYhQ6xTx=4uxBrGJLL+TYyiG65hYHFz0SWUnD=oQ@mail.gmail.com>
In-Reply-To: <CAFEAcA-mBVxYhQ6xTx=4uxBrGJLL+TYyiG65hYHFz0SWUnD=oQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 05/32] target-arm: make arm_current_el()
	return EL3
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Sergey Fedorov <serge.fdrv@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, Fabian Aggeler <aggelerf@ethz.ch>, Greg Bellows <greg.bellows@linaro.org>

On 01/19/2015 11:00 AM, Peter Maydell wrote:
> Alternatively (better!), for a lot of the tlb_flush()es triggered
> by target-arm code we could be more precise about the affected
> mmu_idx values, since the common case is going to be
> "NS EL1 did something that needs a TLB flush", and by definition
> that can't affect TLB entries for EL2, EL3 or S-EL1/EL0.
> 
> So I think my preference would be to use 7 mmu indexes,
> and add a tlb_flush_mmuidx() function. (Assuming I'm
> not missing anything that makes that not workable...)

That new interface does seem very reasonable.

As to whether you've missed something in the ARM semantics,
I guess we'll find out.  ;-)


r~