From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37321)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jike.song@intel.com>) id 1YDQUQ-0001C8-8F
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 23:32:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jike.song@intel.com>) id 1YDQUN-0006ad-3r
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 23:32:30 -0500
Received: from mga02.intel.com ([134.134.136.20]:1564)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jike.song@intel.com>) id 1YDQUM-0006ZO-Uf
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 23:32:27 -0500
Message-ID: <54BDD965.4090904@intel.com>
Date: Tue, 20 Jan 2015 12:28:21 +0800
From: Jike Song <jike.song@intel.com>
MIME-Version: 1.0
References: <1421659723-2496-1-git-send-email-tiejun.chen@intel.com>	
	<1421659723-2496-4-git-send-email-tiejun.chen@intel.com>
	<1421667612.3610.17.camel@nilsson.home.kraxel.org>
	<54BDC2DB.2000003@intel.com>
In-Reply-To: <54BDC2DB.2000003@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v6][PATCH 03/10] piix: create host bridge to
	passthrough
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: mst@redhat.com, allen.m.kay@intel.com, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, aliguori@amazon.com, yang.z.zhang@intel.com, pbonzini@redhat.com, rth@twiddle.net

On 01/20/2015 10:52 AM, Chen, Tiejun wrote:
> On 2015/1/19 19:40, Gerd Hoffmann wrote:
>> On Mo, 2015-01-19 at 17:28 +0800, Tiejun Chen wrote:
>>> +static void xen_igd_passthrough_i440fx_class_init(ObjectClass *klass,
>>> +                                                  void *data)
>>> +{
>>> +    DeviceClass *dc = DEVICE_CLASS(klass);
>>> +
>>> +    dc->desc = "IGD PT XEN Host bridge";
>>> +}
>>
>> IMO "xen" naming should go away here too.
>>

I would agree with this.

In fact, this piece of code could possibly be used by:

  a) IGD passthru for Xen and KVM, and/or:
  b) IGD Mediated passthru for Xen and KVM, i.e. XenGT/KVMGT

So it looks better if have "xen" naming purged :)

>
> Its easy to do but we need to wait KvmGT guys' response, so now it makes
> sense to leave "xen" as a prefix since this just work in xen side.
>
> Thanks
> Tiejun
>

--
Thanks,
Jike