From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39051)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YDVFL-0003fn-Qc
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 04:37:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YDVFH-0006oH-Ge
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 04:37:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52555)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YDVFH-0006o2-AC
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 04:37:11 -0500
Message-ID: <54BE21BD.5020707@redhat.com>
Date: Tue, 20 Jan 2015 11:37:01 +0200
From: Marcel Apfelbaum <marcel@redhat.com>
MIME-Version: 1.0
References: <1418954562-13716-1-git-send-email-imammedo@redhat.com>
	<1418954562-13716-42-git-send-email-imammedo@redhat.com>
	<54BCFBB1.60806@redhat.com> <20150119215537.GC11452@redhat.com>
In-Reply-To: <20150119215537.GC11452@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 41/47] pc: acpi-build: create PCI0._CRS
	dynamically
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, drjones@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, Marcel Apfelbaum <marcel.a@redhat.com>

On 01/19/2015 11:55 PM, Michael S. Tsirkin wrote:
> On Mon, Jan 19, 2015 at 01:42:25PM +0100, Paolo Bonzini wrote:
>>
>>
>> On 19/12/2014 03:02, Igor Mammedov wrote:
>>> Replace template patching and runtime
>>> calculation in _CRS() method with static _CRS
>>> defined in SSDT.
>>>
>>> It also drops manual hole patching for reserved
>>> PCI/MEM/CPU hoptlug MMIO resources and utilizes
>>> the fact that MMIO resources are reserved by
>>> respective child /i.e. PHPR, MHPD, PRES/ containers.
>>>
>>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>>
>> This is a good idea.  It's simpler to just do this in the SSDT than to
>> split it between DSDT and SSDT.  The AML's purpose is just to build a
>> static value anyway.
>>
>> Paolo
>
> I think Marcel has patches going in exactly the reverse
> direction with this.
> Marcel?

Actually I added the CRS for the extra root buses in SSDT.
The reason is that it depends on user input.

By the way, I have the code for creating the CRS in code rather that in
the file based on Igor's series.

Thanks,
Marcel

>