From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55270)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YDWJM-0006tS-Cd
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 05:45:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YDWJH-0005sX-Jn
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 05:45:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43731)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YDWJH-0005sJ-D4
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 05:45:23 -0500
Message-ID: <54BE3191.3040901@redhat.com>
Date: Tue, 20 Jan 2015 11:44:33 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1421702918-27143-1-git-send-email-hpoussin@reactos.org>
	<1421702918-27143-2-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1421702918-27143-2-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/7] isa: add memory space parameter to
	isa_bus_new
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?windows-1252?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@amazon.com>, Leon Alrae <leon.alrae@imgtec.com>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>



On 19/01/2015 22:28, Herv=E9 Poussineau wrote:
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index f0a3201..8f932c9 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -208,7 +208,7 @@ static void pc_init1(MachineState *machine,
>      } else {
>          pci_bus =3D NULL;
>          i440fx_state =3D NULL;
> -        isa_bus =3D isa_bus_new(NULL, system_io);
> +        isa_bus =3D isa_bus_new(NULL, get_system_memory(), system_io);
>          no_hpet =3D 1;
>      }
>      isa_bus_irqs(isa_bus, gsi);

I suspect the right thing to do would be the PCI address space, since
the ISA bridge on real hardware has BusMaster+ set in lspci.  But if
firmware doesn't set it for virtual machines, passing
get_system_memory() is probably a good idea.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>