From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDae1-000409-Gp for qemu-devel@nongnu.org; Tue, 20 Jan 2015 10:23:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDadx-0005lB-23 for qemu-devel@nongnu.org; Tue, 20 Jan 2015 10:23:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDadw-0005jt-Qf for qemu-devel@nongnu.org; Tue, 20 Jan 2015 10:23:01 -0500 Message-ID: <54BE72CA.1030106@redhat.com> Date: Tue, 20 Jan 2015 08:22:50 -0700 From: Eric Blake MIME-Version: 1.0 References: <2ACCDD16-AFEC-49BF-8BD3-3A3EC55DB2E5@gmail.com> <87oapt7sxo.fsf@blackfin.pond.sub.org> <2AB4B322-B3CF-4609-B57E-32B93C124761@gmail.com> In-Reply-To: <2AB4B322-B3CF-4609-B57E-32B93C124761@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oT4wbWMLpiJqnrjDuCRlxR2NoGXBeLCkd" Subject: Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid , Markus Armbruster Cc: Kevin Wolf , Peter Maydell , qemu-devel qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oT4wbWMLpiJqnrjDuCRlxR2NoGXBeLCkd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/20/2015 07:29 AM, Programmingkid wrote: >=20 > On Jan 20, 2015, at 3:33 AM, Markus Armbruster wrote: >=20 >> Programmingkid writes: >> >>> Subject was:=20 >>> Re: [PATCH v7] block/raw-posix.c: Fixes raw_getlength()=20 >>> on Mac OS X so that it reports the correct length of a real CD >> >> Patch history information goes... >> >> ... below the --- divider. >=20 > I thought I did this. The information above is the description of the p= atch.=20 > Not its history. Anything that mentions 'v7' is history. When you read 'git log', you will not see mentions of 'v7', because no one cares how many tries it took to get a patch into git. Knowing about v7 only matters to the reviewers of v8, hence it is patch history that belongs after the divider= =2E >>> + >>> + if (ioctl(fd, DKIOCGETBLOCKCOUNT, §ors) =3D=3D 0 >>> + && ioctl(fd, DKIOCGETBLOCKSIZE, §or_size) =3D=3D = 0) { Indentation looks off here. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oT4wbWMLpiJqnrjDuCRlxR2NoGXBeLCkd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUvnLKAAoJEKeha0olJ0NqICYH/Rb0SRDl1BvjAaYNzDGGbQOD pi8ffQwrtCsKHr0/f5slIQUNV54AuO/WCzJsPw1mIrhBU1NihyBXo8JchVJL9iEN BAiJMprz8vln31hxr+vrfIjeJvt2HIHhYTBhdws2w6Gbp3sCn6sqpYHcoD41Gyvz XGg/q0F3/JeOmzMXZKxS52W0pxz+qiZN86F3TTPsL+rGgG/ZjzsvFVTw1BnVr1wE ZZxnC8F0YwM0VelX+F6rp3vFDcflfscCw0WSKKuYG9tw12W56LNcMulAwyKDULNJ wPOiA7qUFHNxKukmr/OXDMyArfl7iBOnjenGpogl4qcH2F3BWEzwuDlQ0PriQoA= =blzy -----END PGP SIGNATURE----- --oT4wbWMLpiJqnrjDuCRlxR2NoGXBeLCkd--