From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49717)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YDbUj-0007Se-27
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:17:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YDbUe-0008JN-Sd
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:17:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47417)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YDbUe-0008JD-Jj
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:17:28 -0500
Message-ID: <54BE7F91.5080305@redhat.com>
Date: Tue, 20 Jan 2015 17:17:21 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1421770600-17525-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1421770600-17525-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu-timer.c: Trim list of included headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org



On 20/01/2015 17:16, Peter Maydell wrote:
> qemu-timer.c was including a lot more headers than it needed to,
> presumably for historical reasons. In particular, it included
> ui/console.h; this now tries to pull in <pixman.h>, which will
> cause a compilation failure in --disable-tools --disable-system
> configurations when running "make check" (which builds qemu-timer.c,
> even though the linux-user binaries themselves don't need it).
> 
> Fix this build failure by trimming down the set of included
> headers severely -- we only really need main-loop.h and timer.h.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I'm not sure exactly when this broke -- it's not a config I
> run as part of pullreq processing.
> 
>  qemu-timer.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/qemu-timer.c b/qemu-timer.c
> index 98d9d1b..a77fb47 100644
> --- a/qemu-timer.c
> +++ b/qemu-timer.c
> @@ -22,13 +22,9 @@
>   * THE SOFTWARE.
>   */
>  
> -#include "sysemu/sysemu.h"
> -#include "monitor/monitor.h"
> -#include "ui/console.h"
> -
> -#include "hw/hw.h"
> -
> +#include "qemu/main-loop.h"
>  #include "qemu/timer.h"
> +
>  #ifdef CONFIG_POSIX
>  #include <pthread.h>
>  #endif
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>