From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35060)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YDjMO-0005Cz-CX
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 19:41:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YDjML-0003Fv-2h
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 19:41:28 -0500
Received: from mga02.intel.com ([134.134.136.20]:55750)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YDjMK-0003Fg-Tb
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 19:41:25 -0500
Message-ID: <54BEF5AF.5040108@intel.com>
Date: Wed, 21 Jan 2015 08:41:19 +0800
From: "Chen, Tiejun" <tiejun.chen@intel.com>
MIME-Version: 1.0
References: <1421659723-2496-1-git-send-email-tiejun.chen@intel.com>
	<1421659723-2496-8-git-send-email-tiejun.chen@intel.com>
	<20150120104621.GC26442@redhat.com>
In-Reply-To: <20150120104621.GC26442@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v6][PATCH 07/10] xen,
	gfx passthrough: register a isa bridge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: allen.m.kay@intel.com, qemu-devel@nongnu.org, aliguori@amazon.com, yang.z.zhang@intel.com, pbonzini@redhat.com, rth@twiddle.net

>> +
>> +    if (pch_dev_id == 0xffff) {
>> +        fprintf(stderr, "unsupported PCH!\n");
>
> I would drop this fprintf: this likely means a newer
> card, so the bridge is not necessary.

Okay.

>
>> +        return;
>> +    }
>> +
>> +    /* Currently IGD drivers always need to access PCH by 1f.0. */
>> +    pci_dev = pci_create_simple(d->bus, PCI_DEVFN(0x1f, 0),
>> +                                "xen-igd-passthrough-isa-bridge");
>> +
>> +    /*
>> +     * Identify PCH card with its own real vendor/device ids.
>
> This no longer holds I think.

You're right.

Thanks
Tiejun