From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: allen.m.kay@intel.com, qemu-devel@nongnu.org,
aliguori@amazon.com, yang.z.zhang@intel.com, pbonzini@redhat.com,
rth@twiddle.net
Subject: Re: [Qemu-devel] [v6][PATCH 07/10] xen, gfx passthrough: register a isa bridge
Date: Wed, 21 Jan 2015 08:46:39 +0800 [thread overview]
Message-ID: <54BEF6EF.1050505@intel.com> (raw)
In-Reply-To: <20150120110303.GE26442@redhat.com>
>> +static void
>> +xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s,
>> + XenHostPCIDevice *dev)
>> +{
>
> I suggest this implementation, and the table, are moved
> to the same file where igd-passthrough-isa-bridge
> is implemented. The function can get PCIDevice *d, this way
> it's not xen specific.
Absolutely, you're right.
Actually I already start to work this way since Gerd said this should
have a common between Xen and Kvm(KvmGT).
>
>
>
>> + struct PCIDevice *pci_dev;
>
> pls rename bridge_dev;
Okay.
Thanks
Tiejun
next prev parent reply other threads:[~2015-01-21 0:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 9:28 [Qemu-devel] [v6][PATCH 00/10] xen: add Intel IGD passthrough support Tiejun Chen
2015-01-19 9:28 ` [Qemu-devel] [v6][PATCH 01/10] i440fx: make types configurable at run-time Tiejun Chen
2015-01-19 11:36 ` Gerd Hoffmann
2015-01-20 2:48 ` Chen, Tiejun
2015-01-20 8:25 ` Gerd Hoffmann
2015-01-20 8:32 ` Jike Song
2015-01-20 5:08 ` Chen, Tiejun
2015-01-19 9:28 ` [Qemu-devel] [v6][PATCH 02/10] pc_init1: pass parameters just with types Tiejun Chen
2015-01-19 9:28 ` [Qemu-devel] [v6][PATCH 03/10] piix: create host bridge to passthrough Tiejun Chen
2015-01-19 11:40 ` Gerd Hoffmann
2015-01-20 2:52 ` Chen, Tiejun
2015-01-20 4:28 ` Jike Song
2015-01-20 4:56 ` Chen, Tiejun
2015-01-19 9:28 ` [Qemu-devel] [v6][PATCH 04/10] hw/pci-assign: split pci-assign.c Tiejun Chen
2015-01-19 9:28 ` [Qemu-devel] [v6][PATCH 05/10] xen, gfx passthrough: basic graphics passthrough support Tiejun Chen
2015-01-19 11:45 ` Gerd Hoffmann
2015-01-20 3:14 ` Chen, Tiejun
2015-01-20 8:14 ` Gerd Hoffmann
2015-01-21 7:04 ` Chen, Tiejun
2015-01-19 9:28 ` [Qemu-devel] [v6][PATCH 06/10] xen, gfx passthrough: retrieve VGA BIOS to work Tiejun Chen
2015-01-19 9:28 ` [Qemu-devel] [v6][PATCH 07/10] xen, gfx passthrough: register a isa bridge Tiejun Chen
2015-01-19 11:57 ` Gerd Hoffmann
2015-01-19 13:58 ` Michael S. Tsirkin
2015-01-20 2:46 ` Chen, Tiejun
2015-01-20 10:46 ` Michael S. Tsirkin
2015-01-21 0:41 ` Chen, Tiejun
2015-01-20 11:03 ` Michael S. Tsirkin
2015-01-21 0:46 ` Chen, Tiejun [this message]
2015-01-19 9:28 ` [Qemu-devel] [v6][PATCH 08/10] xen, gfx passthrough: support Intel IGD passthrough with VT-D Tiejun Chen
2015-01-20 10:58 ` Michael S. Tsirkin
2015-01-21 3:16 ` Chen, Tiejun
2015-01-22 2:21 ` Kay, Allen M
2015-01-19 9:28 ` [Qemu-devel] [v6][PATCH 09/10] xen, gfx passthrough: register host bridge specific to passthrough Tiejun Chen
2015-01-19 9:28 ` [Qemu-devel] [v6][PATCH 10/10] xen, gfx passthrough: add opregion mapping Tiejun Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BEF6EF.1050505@intel.com \
--to=tiejun.chen@intel.com \
--cc=aliguori@amazon.com \
--cc=allen.m.kay@intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).