From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38425)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YDjRV-0006wb-RL
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 19:46:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YDjRS-0005VI-EW
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 19:46:45 -0500
Received: from mga02.intel.com ([134.134.136.20]:6638)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1YDjRS-0005V8-8U
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 19:46:42 -0500
Message-ID: <54BEF6EF.1050505@intel.com>
Date: Wed, 21 Jan 2015 08:46:39 +0800
From: "Chen, Tiejun" <tiejun.chen@intel.com>
MIME-Version: 1.0
References: <1421659723-2496-1-git-send-email-tiejun.chen@intel.com>
	<1421659723-2496-8-git-send-email-tiejun.chen@intel.com>
	<20150120110303.GE26442@redhat.com>
In-Reply-To: <20150120110303.GE26442@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v6][PATCH 07/10] xen,
	gfx passthrough: register a isa bridge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: allen.m.kay@intel.com, qemu-devel@nongnu.org, aliguori@amazon.com, yang.z.zhang@intel.com, pbonzini@redhat.com, rth@twiddle.net

>> +static void
>> +xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s,
>> +                                      XenHostPCIDevice *dev)
>> +{
>
> I suggest this implementation, and the table, are moved
> to the same file where igd-passthrough-isa-bridge
> is implemented. The function can get PCIDevice *d, this way
> it's not xen specific.

Absolutely, you're right.

Actually I already start to work this way since Gerd said this should 
have a common between Xen and Kvm(KvmGT).

>
>
>
>> +    struct PCIDevice *pci_dev;
>
> pls rename bridge_dev;

Okay.

Thanks
Tiejun