From: Eric Blake <eblake@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] qemu-ga-win: Fail loudly on bare 'set-time'
Date: Wed, 21 Jan 2015 16:25:52 -0700 [thread overview]
Message-ID: <54C03580.3070600@redhat.com> (raw)
In-Reply-To: <c5be993de2bebdab5c695ef84decc4a35eb8d139.1421838590.git.mprivozn@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
On 01/21/2015 04:09 AM, Michal Privoznik wrote:
> The command is not implemented correctly yet. The documentation allows
> to not pass any value to set, in which case the time is re-read from
> RTC. However, reading CMOS on Windows is not trivial to implement. So
> instead of pretending we've set the correct time, fail explicitly.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> qga/commands-win32.c | 44 ++++++++++++++++++++++----------------------
> qga/qapi-schema.json | 5 ++++-
> 2 files changed, 26 insertions(+), 23 deletions(-)
Harder to read because of indentation change, but fairly simple. I'm
okay with the code change, but I'll leave it to someone more familiar
with Windows on whether this is the right technical decision.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-01-21 23:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 11:09 [Qemu-devel] [PATCH] qemu-ga-win: Fail loudly on bare 'set-time' Michal Privoznik
2015-01-21 23:25 ` Eric Blake [this message]
2015-02-17 1:34 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C03580.3070600@redhat.com \
--to=eblake@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).