From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YE4gT-0005A0-HN for qemu-devel@nongnu.org; Wed, 21 Jan 2015 18:27:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YE4gP-0003ED-Dj for qemu-devel@nongnu.org; Wed, 21 Jan 2015 18:27:37 -0500 Received: from resqmta-ch2-01v.sys.comcast.net ([69.252.207.33]:50673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YE4gP-0003E4-8G for qemu-devel@nongnu.org; Wed, 21 Jan 2015 18:27:33 -0500 Message-ID: <54C03580.3070600@redhat.com> Date: Wed, 21 Jan 2015 16:25:52 -0700 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="g1hTHJ39JR5esqXErQiDfMvdM6GBSl8xP" Subject: Re: [Qemu-devel] [PATCH] qemu-ga-win: Fail loudly on bare 'set-time' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --g1hTHJ39JR5esqXErQiDfMvdM6GBSl8xP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/21/2015 04:09 AM, Michal Privoznik wrote: > The command is not implemented correctly yet. The documentation allows > to not pass any value to set, in which case the time is re-read from > RTC. However, reading CMOS on Windows is not trivial to implement. So > instead of pretending we've set the correct time, fail explicitly. >=20 > Signed-off-by: Michal Privoznik > --- > qga/commands-win32.c | 44 ++++++++++++++++++++++----------------------= > qga/qapi-schema.json | 5 ++++- > 2 files changed, 26 insertions(+), 23 deletions(-) Harder to read because of indentation change, but fairly simple. I'm okay with the code change, but I'll leave it to someone more familiar with Windows on whether this is the right technical decision. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --g1hTHJ39JR5esqXErQiDfMvdM6GBSl8xP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUwDWAAAoJEKeha0olJ0NqxMkH/0wWozm8D5velFtJtMPOLtYl QFfuSeXYKKOrrXrQDmxzlFx+/LmtxB0UdDjAFe7N4Agq1joyjzU0h9bXmoJ+a4kH Xk8u3om3YmbZNeqCZuB7FZDawo0Lxg3i61SwkHp3MqvPm9AcSgOXbjx+MrnPJaIq mV1bRn9e5FIz8O0al3L7tB7lYd1wHVzm/WoCMPHk3LorjHk8E1jWcwi0SgCTRVfe w9XERytoT9v+ELfuJTY4hpuSDr+MhT6aTXVmHAh5fePu40NL+sFfvApcJXc4+pdJ 9AL7J/A7R/fRX/psJFAV+B7FfUEaluh20tNiX5XNJLGcI47PH1n5E2OKSDcMBS4= =emXk -----END PGP SIGNATURE----- --g1hTHJ39JR5esqXErQiDfMvdM6GBSl8xP--