From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEHyh-0008Bb-DV for qemu-devel@nongnu.org; Thu, 22 Jan 2015 08:39:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEHyc-0004ow-C7 for qemu-devel@nongnu.org; Thu, 22 Jan 2015 08:39:19 -0500 Message-ID: <54C0FD80.6010806@suse.de> Date: Thu, 22 Jan 2015 14:39:12 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1421856072-25026-1-git-send-email-mark.cave-ayland@ilande.co.uk> <1421856072-25026-8-git-send-email-mark.cave-ayland@ilande.co.uk> In-Reply-To: <1421856072-25026-8-git-send-email-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 7/7] openpic: fix up loadvm under -M mac99 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-ppc@nongnu.org On 21.01.15 17:01, Mark Cave-Ayland wrote: > Issuing loadvm under -M mac99 would fail for two reasons: firstly an incorrect > version number for openpic would cause openpic_load() to abort, and secondly > a cut/paste error when restoring the IVPR and IDR registers caused subsequent > vmstate sections to become misaligned and abort early. > > Signed-off-by: Mark Cave-Ayland Thanks a lot for all the work you put into this. Do you think you understand enough to the OpenPIC code by now to be able to convert it to VMState instead? That would get rid of the whole class of problems altogether and make sure we didn't overlook something subtle somewhere else in the code. Alex