From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60033)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YEIHP-0007a1-TH
	for qemu-devel@nongnu.org; Thu, 22 Jan 2015 08:58:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YEIHL-0007KL-Nd
	for qemu-devel@nongnu.org; Thu, 22 Jan 2015 08:58:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52816)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YEIHL-0007Ju-Fr
	for qemu-devel@nongnu.org; Thu, 22 Jan 2015 08:58:35 -0500
Message-ID: <54C101FD.2050006@redhat.com>
Date: Thu, 22 Jan 2015 14:58:21 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1421920426-16878-1-git-send-email-borntraeger@de.ibm.com>
In-Reply-To: <1421920426-16878-1-git-send-email-borntraeger@de.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] sparse: Fix build with sparse on .S files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>



On 22/01/2015 10:53, Christian Borntraeger wrote:
> rules.mak has a rule for .S files using CPP. This will result in
> errors like
>   CPP   s390-ccw/start.asm
>  cc: error: unrecognized command line option '-Wbitwise'
> 
> Lets also redefine CPP in case of --enable-sparse.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  configure | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index 47048f0..3bdda2e 100755
> --- a/configure
> +++ b/configure
> @@ -4909,6 +4909,7 @@ echo "QEMU_CFLAGS=$QEMU_CFLAGS" >> $config_host_mak
>  echo "QEMU_INCLUDES=$QEMU_INCLUDES" >> $config_host_mak
>  if test "$sparse" = "yes" ; then
>    echo "CC           := REAL_CC=\"\$(CC)\" cgcc"       >> $config_host_mak
> +  echo "CPP          := REAL_CC=\"\$(CPP)\" cgcc"      >> $config_host_mak
>    echo "CXX          := REAL_CC=\"\$(CXX)\" cgcc"      >> $config_host_mak
>    echo "HOST_CC      := REAL_CC=\"\$(HOST_CC)\" cgcc"  >> $config_host_mak
>    echo "QEMU_CFLAGS  += -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-non-pointer-null" >> $config_host_mak
> 

Queued, thanks.

Paolo