From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] iotests: Test prefix for supported_oses in Python
Date: Thu, 22 Jan 2015 12:42:30 -0500 [thread overview]
Message-ID: <54C13686.8050800@redhat.com> (raw)
In-Reply-To: <1421945543-15607-1-git-send-email-mreitz@redhat.com>
On 2015-01-22 at 11:52, Max Reitz wrote:
> sys.platform may be set to "linux2" instead of just "linux" (in theory,
> it could even be set to "linux3" or something else). The Python
> documentation on sys.platform recommends testing the prefix of the
> platform against "linux", so we should do that.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/iotests.py | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
NACK, somehow missed the patch from Fam himself. (And then I didn't use
Stefan's block branch but Kevin's, so it was missing there, because
Stefan's pull request last week apparently didn't go through)
So it's already fixed and this patch is no longer required. Thanks John
for pointing it out to me!
Max
prev parent reply other threads:[~2015-01-22 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 16:52 [Qemu-devel] [PATCH] iotests: Test prefix for supported_oses in Python Max Reitz
2015-01-22 17:42 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C13686.8050800@redhat.com \
--to=mreitz@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).