From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YELmL-0005jM-Cx for qemu-devel@nongnu.org; Thu, 22 Jan 2015 12:42:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YELmH-0001Yj-JP for qemu-devel@nongnu.org; Thu, 22 Jan 2015 12:42:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YELmH-0001Ya-CE for qemu-devel@nongnu.org; Thu, 22 Jan 2015 12:42:45 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0MHgWAQ006520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 22 Jan 2015 12:42:33 -0500 Message-ID: <54C13686.8050800@redhat.com> Date: Thu, 22 Jan 2015 12:42:30 -0500 From: Max Reitz MIME-Version: 1.0 References: <1421945543-15607-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1421945543-15607-1-git-send-email-mreitz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iotests: Test prefix for supported_oses in Python List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi On 2015-01-22 at 11:52, Max Reitz wrote: > sys.platform may be set to "linux2" instead of just "linux" (in theory, > it could even be set to "linux3" or something else). The Python > documentation on sys.platform recommends testing the prefix of the > platform against "linux", so we should do that. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) NACK, somehow missed the patch from Fam himself. (And then I didn't use Stefan's block branch but Kevin's, so it was missing there, because Stefan's pull request last week apparently didn't go through) So it's already fixed and this patch is no longer required. Thanks John for pointing it out to me! Max