From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55190)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1YEQpc-0006sQ-ML
	for qemu-devel@nongnu.org; Thu, 22 Jan 2015 18:06:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1YEQpZ-00044Q-Gs
	for qemu-devel@nongnu.org; Thu, 22 Jan 2015 18:06:32 -0500
Received: from fldsmtpe04.verizon.com ([140.108.26.143]:5691)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1YEQpZ-00044L-CY
	for qemu-devel@nongnu.org; Thu, 22 Jan 2015 18:06:29 -0500
From: Don Slutz <dslutz@verizon.com>
Message-ID: <54C18274.6070402@terremark.com>
Date: Thu, 22 Jan 2015 18:06:28 -0500
MIME-Version: 1.0
References: <alpine.DEB.2.02.1501221836360.18131@kaball.uk.xensource.com>
In-Reply-To: <alpine.DEB.2.02.1501221836360.18131@kaball.uk.xensource.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fix QEMU build on Xen/ARM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com, Ian Campbell <Ian.Campbell@citrix.com>, Paul Durrant <paul.durrant@citrix.com>

On 01/22/15 13:46, Stefano Stabellini wrote:
> xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an
> unsigned long argument (in fact xen_pfn_t is defined as uint64_t on
> ARM).
> 
> Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> 
> diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h
> index 519696f..355fbac 100644
> --- a/include/hw/xen/xen_common.h
> +++ b/include/hw/xen/xen_common.h
> @@ -168,14 +168,16 @@ void xen_shutdown_fatal_error(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
>  
>  #ifdef HVM_PARAM_VMPORT_REGS_PFN
>  static inline int xen_get_vmport_regs_pfn(XenXC xc, domid_t dom,
> -                                          unsigned long *vmport_regs_pfn)
> +                                          xen_pfn_t *vmport_regs_pfn)
>  {
> -    return xc_get_hvm_param(xc, dom, HVM_PARAM_VMPORT_REGS_PFN,
> -                            vmport_regs_pfn);
> +    uint64_t value;
> +    return xc_hvm_param_get(xc, dom, HVM_PARAM_VMPORT_REGS_PFN,
> +                            &value);

This is not going to work.  Maybe "int rc =" instead of return?

(See if if this time the reply is not a big mess.)
    -Don Slutz

> +    *vmport_regs_pfn = (xen_pfn_t) value;
>  }
>  #else
>  static inline int xen_get_vmport_regs_pfn(XenXC xc, domid_t dom,
> -                                          unsigned long *vmport_regs_pfn)
> +                                          xen_pfn_t *vmport_regs_pfn)
>  {
>      return -ENOSYS;
>  }
> 
>