From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEZg1-0003NH-RA for qemu-devel@nongnu.org; Fri, 23 Jan 2015 03:33:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEZfw-0007sC-QZ for qemu-devel@nongnu.org; Fri, 23 Jan 2015 03:33:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEZfw-0007s8-J5 for qemu-devel@nongnu.org; Fri, 23 Jan 2015 03:33:08 -0500 Message-ID: <54C20739.6000407@redhat.com> Date: Fri, 23 Jan 2015 10:32:57 +0200 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1421938231-25698-1-git-send-email-imammedo@redhat.com> <1421938231-25698-12-git-send-email-imammedo@redhat.com> In-Reply-To: <1421938231-25698-12-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 11/47] acpi: add acpi_arg0(), acpi_arg1(), acpi_arg2(), acpi_arg3() terms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, drjones@redhat.com, marcel.a@redhat.com, claudio.fontana@huawei.com, mst@redhat.com On 01/22/2015 04:49 PM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/acpi/acpi-build-utils.c | 32 ++++++++++++++++++++++++++++++++ > include/hw/acpi/acpi-build-utils.h | 5 +++++ > 2 files changed, 37 insertions(+) > > diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c > index df5880f..6e10712 100644 > --- a/hw/acpi/acpi-build-utils.c > +++ b/hw/acpi/acpi-build-utils.c > @@ -348,6 +348,38 @@ AcpiAml acpi_name_decl(const char *name, AcpiAml val) > return var; > } Hi Igor, Very nice series!!! > > +/* ACPI 5.0: 20.2.6.1 Arg Objects Encoding: Arg0Op */ > +AcpiAml acpi_arg0(void) > +{ > + AcpiAml var = aml_allocate_internal(0, NON_BLOCK); > + build_append_byte(var.buf, 0x68); /* ARG0 op */ > + return var; > +} Maybe we can have a little code reuse and use something like: static AcpiAml acpi_arg(int idx) { AcpiAml var = aml_allocate_internal(0, NON_BLOCK); build_append_byte(var.buf, 0x68 + idx); /* ARG op */ return var; } and then: AcpiAml acpi_arg0(void) { return acpi_arg(0); } ... I did the same with the local vars. What do you think? Thanks, Marcel > + > +/* ACPI 5.0: 20.2.6.1 Arg Objects Encoding: Arg1Op */ > +AcpiAml acpi_arg1(void) > +{ > + AcpiAml var = aml_allocate_internal(0, NON_BLOCK); > + build_append_byte(var.buf, 0x69); /* ARG1 op */ > + return var; > +} > + > +/* ACPI 5.0: 20.2.6.1 Arg Objects Encoding: Arg2Op */ > +AcpiAml acpi_arg2(void) > +{ > + AcpiAml var = aml_allocate_internal(0, NON_BLOCK); > + build_append_byte(var.buf, 0x6A); /* ARG2 op */ > + return var; > +} > + > +/* ACPI 5.0: 20.2.6.1 Arg Objects Encoding: Arg3Op */ > +AcpiAml acpi_arg3(void) > +{ > + AcpiAml var = aml_allocate_internal(0, NON_BLOCK); > + build_append_byte(var.buf, 0x6B); /* ARG3 op */ > + return var; > +} > + > /* ACPI 5.0: 20.2.5.3 Type 1 Opcodes Encoding: DefIfElse */ > AcpiAml acpi_if(AcpiAml predicate) > { > diff --git a/include/hw/acpi/acpi-build-utils.h b/include/hw/acpi/acpi-build-utils.h > index 9e9ef1a..18d9efa 100644 > --- a/include/hw/acpi/acpi-build-utils.h > +++ b/include/hw/acpi/acpi-build-utils.h > @@ -26,6 +26,11 @@ AcpiAml acpi_return(AcpiAml val); > AcpiAml acpi_int(const uint64_t val); > AcpiAml GCC_FMT_ATTR(1, 2) acpi_name(const char *name_format, ...); > AcpiAml acpi_name_decl(const char *name, AcpiAml val); > +AcpiAml acpi_arg0(void); > +AcpiAml acpi_arg1(void); > +AcpiAml acpi_arg2(void); > +AcpiAml acpi_arg3(void); > + > /* Block ASL object primitives */ > AcpiAml acpi_if(AcpiAml predicate); > AcpiAml acpi_method(const char *name, int arg_count); >