From: Chen Gang S <gang.chen@sunrus.com.cn>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Chris Metcalf <cmetcalf@ezchip.com>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base
Date: Fri, 23 Jan 2015 22:01:12 +0800 [thread overview]
Message-ID: <54C25428.7030304@sunrus.com.cn> (raw)
In-Reply-To: <CAFEAcA9WwAT4ft9Hk0Apoa1MG1PeGOZ660OtK+qvJYeJvVMCGg@mail.gmail.com>
On 1/23/15 19:21, Peter Maydell wrote:
> On 23 January 2015 at 10:57, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
>>
>> Thank you for all of your work.
>>
>> I plan to let qemu support tile architecture: "can let gcc run testsuite
>> with qemu for tile". It is really hard to me, but I should try, it is my
>> duty (I met it, and it's within my boarder, although no one pay for me).
>> :-)
>
>> Welcome any ideas, suggestions and completions by any members
>
> My single biggest suggestion is to make sure you split the work
> up so that you can post parts of it as you go along. Typically
> for a target-*/ new port that looks something like
> * initial framework, but no instruction decode (so all instructions
> just throw an illegal instruction exception)
> * support for one or a few simple classes of instruction
> * gradually fill in the gaps of missing instructions
>
> This way you get the benefit of code review on your early patches,
> so you can write the later ones in line with the comments you
> get on the first patches. We also get to review the code in
> smaller and more manageable chunks.
>
> I think the last target code to go in was target-tricore; you
> could look back in the git history and the archives to get an
> idea of how to structure the patchset and the kinds of review
> comment that patchseries received.
>
That sounds a good idea to me. In this way, I will bother qemu upstream
frequently (which also means will get much help from qemu upstream for
tile, frequently).
If can get much help from qemu upstream frequently (in above way), I
guess, it is possible to me to finish it: "let gcc run testsuit with
tile qemu". :-)
What I shall do for tile qemu should obey the related license of qemu
(all the related code should belong to qemu upstream). If necessary to
follow some copyright working flow, please let me know, I shall follow.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2015-01-23 13:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 10:07 [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base Chen Gang S
2015-01-23 10:08 ` Peter Maydell
2015-01-23 10:57 ` Chen Gang S
2015-01-23 11:21 ` Peter Maydell
2015-01-23 14:01 ` Chen Gang S [this message]
2015-01-23 13:55 ` Peter Maydell
2015-01-23 21:10 ` Chen Gang S
2015-01-27 15:39 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C25428.7030304@sunrus.com.cn \
--to=gang.chen@sunrus.com.cn \
--cc=cmetcalf@ezchip.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).