From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEfWi-0006fK-Bi for qemu-devel@nongnu.org; Fri, 23 Jan 2015 09:48:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEfWf-0004b0-5i for qemu-devel@nongnu.org; Fri, 23 Jan 2015 09:48:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEfWe-0004av-UR for qemu-devel@nongnu.org; Fri, 23 Jan 2015 09:47:57 -0500 Message-ID: <54C25F16.4050606@redhat.com> Date: Fri, 23 Jan 2015 09:47:50 -0500 From: Max Reitz MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: vhdx - force FileOffsetMB field to '0' for certain block states List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, amulya.lokesha@emc.com, stefanha@redhat.com On 2015-01-20 at 16:01, Jeff Cody wrote: > The v1.0.0 spec calls out PAYLOAD_BLOCK_ZERO FileOffsetMB field as being > 'reserved'. In practice, this means that Hyper-V will fail to read a > disk image with PAYLOAD_BLOCK_ZERO block states with a FileOffsetMB > value other than 0. > > The other states that indicate a block that is not there > (PAYLOAD_BLOCK_UNDEFINED, PAYLOAD_BLOCK_NOT_PRESENT, > PAYLOAD_BLOCK_UNMAPPED) have multiple options for what FileOffsetMB may > be set to, and '0' is explicitly called out as an option. > > For all the above states, we will also just set the FileOffsetMB value > to 0. > > Signed-off-by: Jeff Cody > --- > block/vhdx.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/XanClic/qemu/commits/block