From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEh3h-0005nm-Ir for qemu-devel@nongnu.org; Fri, 23 Jan 2015 11:26:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEh3c-0006Xv-JK for qemu-devel@nongnu.org; Fri, 23 Jan 2015 11:26:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEh3c-0006Xp-Bn for qemu-devel@nongnu.org; Fri, 23 Jan 2015 11:26:04 -0500 Message-ID: <54C27602.5070500@redhat.com> Date: Fri, 23 Jan 2015 09:25:38 -0700 From: Eric Blake MIME-Version: 1.0 References: <1508539.cfTQauU1Ry@javinlg> <20150120160807.GM8982@edamame.cdg.redhat.com> <17343709.DGNVESbVIr@javinlg> In-Reply-To: <17343709.DGNVESbVIr@javinlg> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="02KkKwjdU1hr74etUV5e3dBfEcfRdIOit" Subject: Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Javier Celaya , Christophe Fergeau Cc: devel@flexvm.es, spice-devel , Gerd Hoffmann , Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --02KkKwjdU1hr74etUV5e3dBfEcfRdIOit Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/23/2015 07:06 AM, Javier Celaya wrote: > Hello, this is the patch with the version check. Christophe, can you ch= eck=20 > that the version is the correct one? >=20 >=20 > Recently, SPICE included the lz4 compression algorithm. This patch adds= > a command line option to select it. > --- > ui/spice-core.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/ui/spice-core.c b/ui/spice-core.c > index 6467fa4..dadcae9 100644 > --- a/ui/spice-core.c > +++ b/ui/spice-core.c > @@ -359,6 +359,9 @@ static const char *compression_names[] =3D { > [ SPICE_IMAGE_COMPRESS_QUIC ] =3D "quic", > [ SPICE_IMAGE_COMPRESS_GLZ ] =3D "glz", > [ SPICE_IMAGE_COMPRESS_LZ ] =3D "lz", > +#if SPICE_SERVER_VERSION >=3D 0x000c07 > + [ SPICE_IMAGE_COMPRESS_LZ4 ] =3D "lz4", How is libvirt going to introspect whether the command line supports this option? Is there some QMP command that lists the set of valid compression formats understood by a given qemu binary? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --02KkKwjdU1hr74etUV5e3dBfEcfRdIOit Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUwnYCAAoJEKeha0olJ0NqME4H/2/P6NGO+k5hqZUs6QDYPDYo tqYN9Xuknubzz2kZNNLprP/TcTvWi+kHltYJE3yX8p1gHJmfMWofjGeBzmFIO/UP YG9ZdMuuCpXPe7b2dDPUKkzugZeXgUvEJNYZbmlTtM1APoj1CkhoAzQed4IIp8zf Up9c0iWfCrEt03Twi1Zj9w5oFuF/u343lldXZO92XVav2q4sr3iOHfKjmmVmE+J9 3byEMICSvmKOABSQI+ICGeEodYIZDuGlDnm7GsfMukyyTxYpBVNadUhM9SEQPus1 VShY23pA2QJmiI6TAOWvJBcrTWlqrDcNPRm1/Wle0IuVXYGFm+CjNMpVfii3sBM= =BndU -----END PGP SIGNATURE----- --02KkKwjdU1hr74etUV5e3dBfEcfRdIOit--