From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YF5sm-00037K-7o for qemu-devel@nongnu.org; Sat, 24 Jan 2015 13:56:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YF5si-0003vC-UB for qemu-devel@nongnu.org; Sat, 24 Jan 2015 13:56:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YF5si-0003v7-MI for qemu-devel@nongnu.org; Sat, 24 Jan 2015 13:56:28 -0500 Message-ID: <54C3EAC5.30205@redhat.com> Date: Sat, 24 Jan 2015 19:56:05 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1422091280-14532-1-git-send-email-zhaoshenglong@huawei.com> <1422091280-14532-12-git-send-email-zhaoshenglong@huawei.com> In-Reply-To: <1422091280-14532-12-git-send-email-zhaoshenglong@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 11/11] hw/arm/virt: Enable dynamic generation of ACPI v5.1 tables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, wanghaibin.wang@huawei.com, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, imammedo@redhat.com, pbonzini@redhat.com, christoffer.dall@linaro.org On 01/24/15 10:21, Shannon Zhao wrote: > Expose the needed device information to the table generation > insfrastructure and register a machine_init_done notify to > call virt_acpi_build(). > > Add CONFIG_ACPI to arm-softmmu.mak, but there is compile error. > Don't include unnecessary file for ARM. Maybe this way is not > right, fix me please. > > Signed-off-by: Shannon Zhao > --- > default-configs/arm-softmmu.mak | 1 + > default-configs/i386-softmmu.mak | 3 ++ > default-configs/mips-softmmu.mak | 3 ++ > default-configs/mips64-softmmu.mak | 3 ++ > default-configs/mips64el-softmmu.mak | 3 ++ > default-configs/mipsel-softmmu.mak | 3 ++ > default-configs/x86_64-softmmu.mak | 3 ++ > hw/acpi/Makefile.objs | 5 ++- > hw/arm/virt.c | 59 +++++++++++++++++++++++++++++++-- > hw/i2c/Makefile.objs | 2 +- > 10 files changed, 78 insertions(+), 7 deletions(-) > diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs > index cad0355..4e3f15f 100644 > --- a/hw/acpi/Makefile.objs > +++ b/hw/acpi/Makefile.objs > @@ -1,5 +1,6 @@ > -common-obj-$(CONFIG_ACPI) += core.o piix4.o ich9.o pcihp.o cpu_hotplug.o > -common-obj-$(CONFIG_ACPI) += memory_hotplug.o > +common-obj-$(CONFIG_ACPI_CORE) += core.o piix4.o ich9.o pcihp.o > +common-obj-$(CONFIG_ACPI_HOTPLUG) += cpu_hotplug.o This line has a typo and it breaks the linking of qemu-system-x86_64. You need to say CONFIG_ACPI_CPU_HOTPLUG here, not CONFIG_ACPI_HOTPLUG Thanks Laszlo