From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFYyh-0000aj-U5 for qemu-devel@nongnu.org; Sun, 25 Jan 2015 21:00:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFYye-00030v-Nh for qemu-devel@nongnu.org; Sun, 25 Jan 2015 21:00:35 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:52017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFYye-00030T-4H for qemu-devel@nongnu.org; Sun, 25 Jan 2015 21:00:32 -0500 Message-ID: <54C59F9D.1080906@huawei.com> Date: Mon, 26 Jan 2015 09:59:57 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1422091280-14532-1-git-send-email-zhaoshenglong@huawei.com> <1422091280-14532-12-git-send-email-zhaoshenglong@huawei.com> <54C3EAC5.30205@redhat.com> In-Reply-To: <54C3EAC5.30205@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 11/11] hw/arm/virt: Enable dynamic generation of ACPI v5.1 tables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, wanghaibin.wang@huawei.com, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, imammedo@redhat.com, pbonzini@redhat.com, christoffer.dall@linaro.org On 2015/1/25 2:56, Laszlo Ersek wrote: > On 01/24/15 10:21, Shannon Zhao wrote: >> Expose the needed device information to the table generation >> insfrastructure and register a machine_init_done notify to >> call virt_acpi_build(). >> >> Add CONFIG_ACPI to arm-softmmu.mak, but there is compile error. >> Don't include unnecessary file for ARM. Maybe this way is not >> right, fix me please. >> >> Signed-off-by: Shannon Zhao >> --- >> default-configs/arm-softmmu.mak | 1 + >> default-configs/i386-softmmu.mak | 3 ++ >> default-configs/mips-softmmu.mak | 3 ++ >> default-configs/mips64-softmmu.mak | 3 ++ >> default-configs/mips64el-softmmu.mak | 3 ++ >> default-configs/mipsel-softmmu.mak | 3 ++ >> default-configs/x86_64-softmmu.mak | 3 ++ >> hw/acpi/Makefile.objs | 5 ++- >> hw/arm/virt.c | 59 +++++++++++++++++++++++++++++++-- >> hw/i2c/Makefile.objs | 2 +- >> 10 files changed, 78 insertions(+), 7 deletions(-) > >> diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs >> index cad0355..4e3f15f 100644 >> --- a/hw/acpi/Makefile.objs >> +++ b/hw/acpi/Makefile.objs >> @@ -1,5 +1,6 @@ >> -common-obj-$(CONFIG_ACPI) += core.o piix4.o ich9.o pcihp.o cpu_hotplug.o >> -common-obj-$(CONFIG_ACPI) += memory_hotplug.o >> +common-obj-$(CONFIG_ACPI_CORE) += core.o piix4.o ich9.o pcihp.o >> +common-obj-$(CONFIG_ACPI_HOTPLUG) += cpu_hotplug.o > > This line has a typo and it breaks the linking of qemu-system-x86_64. > You need to say > > CONFIG_ACPI_CPU_HOTPLUG > > here, not > > CONFIG_ACPI_HOTPLUG > Laszlo, Thanks. Will fix this. Thanks, Shannon