From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFZMh-00017m-8C for qemu-devel@nongnu.org; Sun, 25 Jan 2015 21:25:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFZMe-0002fd-2z for qemu-devel@nongnu.org; Sun, 25 Jan 2015 21:25:23 -0500 Message-ID: <54C5A408.5000001@cn.fujitsu.com> Date: Mon, 26 Jan 2015 10:18:48 +0800 From: Chen Fan MIME-Version: 1.0 References: <1421898608-10313-1-git-send-email-chen.fan.fnst@cn.fujitsu.com> <54C0B156.3080608@linaro.org> <54C59333.8080005@cn.fujitsu.com> <1400861803.231065.1422237980435.JavaMail.zimbra@redhat.com> In-Reply-To: <1400861803.231065.1422237980435.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Eric Auger On 01/26/2015 10:06 AM, Alex Williamson wrote: > > ----- Original Message ----- >> CC: qemu-trivial@nongnu.org >> >> On 01/22/2015 04:14 PM, Eric Auger wrote: >>> Hi Chen, >>> >>> thanks for correcting this mistake I introduced when moving code from >>> pci to common. >> so, can you check in this patch? > I've got it queued up and while it's clearly an error, I don't see that the fix actually changes the resulting code, the parameter is ignored in the macro. Am I missing something? If that's the case, I'll include it in my next pull request, but I don't see any pressing reason to rush that request. Thanks, Yes, this patch can not affect the result of the code execution for now, but I think it is also a typo mistake, if the macro QLIST_HEAD_INITIALIZER will be changed and using the parameter in the future, this error will be difficultly found. I think the earlier found the earlier fixed. Thanks, Chen > > Alex > >>> On 01/22/2015 04:50 AM, Chen Fan wrote: >>>> Signed-off-by: Chen Fan >>>> --- >>>> hw/vfio/common.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/hw/vfio/common.c b/hw/vfio/common.c >>>> index cf483ff..e71385e 100644 >>>> --- a/hw/vfio/common.c >>>> +++ b/hw/vfio/common.c >>>> @@ -32,7 +32,7 @@ >>>> #include "trace.h" >>>> >>>> struct vfio_group_head vfio_group_list = >>>> - QLIST_HEAD_INITIALIZER(vfio_address_spaces); >>>> + QLIST_HEAD_INITIALIZER(vfio_group_list); >>>> struct vfio_as_head vfio_address_spaces = >>>> QLIST_HEAD_INITIALIZER(vfio_address_spaces); >>>> >>>> >> > . >