From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFZaD-0005FF-Lt for qemu-devel@nongnu.org; Sun, 25 Jan 2015 21:39:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFZaA-0006EL-FD for qemu-devel@nongnu.org; Sun, 25 Jan 2015 21:39:21 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:48145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFZa9-0006E9-T6 for qemu-devel@nongnu.org; Sun, 25 Jan 2015 21:39:18 -0500 Message-ID: <54C5A870.4030601@huawei.com> Date: Mon, 26 Jan 2015 10:37:36 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1422091280-14532-1-git-send-email-zhaoshenglong@huawei.com> <1422091280-14532-3-git-send-email-zhaoshenglong@huawei.com> <20150124162231.GB6293@redhat.com> In-Reply-To: <20150124162231.GB6293@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 02/11] hw/arm/virt-acpi-build: Basic framework for building ACPI tables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, wanghaibin.wang@huawei.com, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, imammedo@redhat.com, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org On 2015/1/25 0:22, Michael S. Tsirkin wrote: > On Sat, Jan 24, 2015 at 05:21:11PM +0800, Shannon Zhao wrote: >> > Introduce a preliminary framework in virt-acpi-build.c with the main >> > ACPI build functions. It exposes the generated ACPI contents to >> > guest over fw_cfg. Some codes borrowed from hw/i386/acpi-build.c. >> > >> > The minimum required ACPI v5.1 tables for ARM are: >> > - RSDP: Initial table that points to XSDT >> > - XSDT: Points to all other tables (except FACS & DSDT) >> > - FADT: Generic information about the machine >> > - DSDT: Holds all information about system devices/peripherals >> > - FACS: Needs to be pointed from FADT >> > >> > Signed-off-by: Shannon Zhao >> > --- >> > hw/arm/Makefile.objs | 1 + >> > hw/arm/virt-acpi-build.c | 263 ++++++++++++++++++++++++++++++++++++++ >> > include/hw/arm/virt-acpi-build.h | 71 ++++++++++ >> > 3 files changed, 335 insertions(+), 0 deletions(-) >> > create mode 100644 hw/arm/virt-acpi-build.c >> > create mode 100644 include/hw/arm/virt-acpi-build.h >> > >> > diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs >> > index 6088e53..8daf825 100644 >> > --- a/hw/arm/Makefile.objs >> > +++ b/hw/arm/Makefile.objs >> > @@ -3,6 +3,7 @@ obj-$(CONFIG_DIGIC) += digic_boards.o >> > obj-y += integratorcp.o kzm.o mainstone.o musicpal.o nseries.o >> > obj-y += omap_sx1.o palm.o realview.o spitz.o stellaris.o >> > obj-y += tosa.o versatilepb.o vexpress.o virt.o xilinx_zynq.o z2.o >> > +obj-$(CONFIG_ACPI) += virt-acpi-build.o >> > >> > obj-y += armv7m.o exynos4210.o pxa2xx.o pxa2xx_gpio.o pxa2xx_pic.o >> > obj-$(CONFIG_DIGIC) += digic.o >> > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c >> > new file mode 100644 >> > index 0000000..4eed0a3 >> > --- /dev/null >> > +++ b/hw/arm/virt-acpi-build.c >> > @@ -0,0 +1,263 @@ >> > +/* Support for generating ACPI tables and passing them to Guests >> > + * >> > + * ARM virt ACPI generation >> > + * >> > + * Copyright (c) 2014 HUAWEI TECHNOLOGIES CO.,LTD. >> > + * >> > + * Author: Shannon Zhao > Since you copied code over, you should append copyright and author > information from the original file to the new one. > Ok, will fix this :-) Thanks, Shannon