From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFecJ-0006Tj-JW for qemu-devel@nongnu.org; Mon, 26 Jan 2015 03:01:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFecG-00053E-Bw for qemu-devel@nongnu.org; Mon, 26 Jan 2015 03:01:51 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:28054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFecD-0004xp-2J for qemu-devel@nongnu.org; Mon, 26 Jan 2015 03:01:48 -0500 Message-ID: <54C5F421.6010302@huawei.com> Date: Mon, 26 Jan 2015 16:00:33 +0800 From: Gonglei MIME-Version: 1.0 References: <1421673818-11224-1-git-send-email-arei.gonglei@huawei.com> <1421673818-11224-5-git-send-email-arei.gonglei@huawei.com> <20150119215120.GA11452@redhat.com> In-Reply-To: <20150119215120.GA11452@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] vhost-scsi: add an ioctl interface to get target id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: "pbonzini@redhat.com" , "Huangweidong (C)" , "qemu-devel@nongnu.org" , "Subo (A)" , "Huangpeng (Peter)" On 2015/1/20 5:51, Michael S. Tsirkin wrote: > On Mon, Jan 19, 2015 at 09:23:38PM +0800, arei.gonglei@huawei.com wrote: >> > From: Gonglei >> > >> > Because vhost-scsi module do not support VHOST_SCSI_GET_TPGT >> > at present, so I use "#if 0" handle it, and set the target >> > default to 1. In addition, channel and lun both are 0 for >> > bootable vhost-scsi device. >> > >> > Signed-off-by: Gonglei >> > Signed-off-by: Bo Su > OK but let's see the kernel patch get accepted first. > Hi, Michael & Paolo Because Qemu only accept an wwpn argument for vhost-scsi, we cannot assign a tpgt. That's say tpg is transparent for Qemu, Qemu doesn't know which tpg can boot, but vhost-scsi driver module doesn't know too for one assigned wwpn. At present, we assume that the first tpg can boot only, and add an ioctl to get the first tpgt, can we? Looking forward to your reply for any suggestions. Regards, -Gonglei