From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56391)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YFiYU-0001b4-A3
	for qemu-devel@nongnu.org; Mon, 26 Jan 2015 07:14:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YFiYR-0004p1-1H
	for qemu-devel@nongnu.org; Mon, 26 Jan 2015 07:14:10 -0500
Received: from szxga03-in.huawei.com ([119.145.14.66]:46548)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YFiYQ-0004nX-BL
	for qemu-devel@nongnu.org; Mon, 26 Jan 2015 07:14:06 -0500
Message-ID: <54C62F69.50104@huawei.com>
Date: Mon, 26 Jan 2015 20:13:29 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1421673818-11224-1-git-send-email-arei.gonglei@huawei.com>
	<1421673818-11224-5-git-send-email-arei.gonglei@huawei.com>
	<20150119215120.GA11452@redhat.com>
	<54C5F421.6010302@huawei.com> <54C6099D.6020707@redhat.com>
In-Reply-To: <54C6099D.6020707@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] vhost-scsi: add an ioctl interface to
 get target id
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, "Huangweidong (C)" <weidong.huang@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "Subo (A)" <subo7@huawei.com>, "Michael S. Tsirkin" <mst@redhat.com>

On 2015/1/26 17:32, Paolo Bonzini wrote:

> 
> 
> On 26/01/2015 09:00, Gonglei wrote:
>> Hi, Michael & Paolo
>>
>> Because Qemu only accept an wwpn argument for vhost-scsi, we
>> cannot assign a tpgt. That's say tpg is transparent for Qemu, Qemu
>> doesn't know which tpg can boot, but vhost-scsi driver module
>> doesn't know too for one assigned wwpn. At present, we assume that
>> the first tpg can boot only, and add an ioctl to get the first tpgt,
>> can we? Looking  forward to your reply for any suggestions.
> 
> That's okay, alternatively you could add a boot_tpgt argument that
> defaults to 1 (is it correct that 0 is not a valid tpgt?).
> 

No, 0 is the minimize valid value. :)
Paolo, where do you think we should add a boot_tpgt argument?

Regards,
-Gonglei