From: Eric Blake <eblake@redhat.com>
To: Javier Celaya <javier.celaya@flexvm.es>,
spice-devel <spice-devel@lists.freedesktop.org>
Cc: devel@flexvm.es, Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE
Date: Mon, 26 Jan 2015 09:25:04 -0700 [thread overview]
Message-ID: <54C66A60.3000204@redhat.com> (raw)
In-Reply-To: <158031087.SthlJV7jIF@javinlg>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On 01/26/2015 01:48 AM, Javier Celaya wrote:
> Sorry, I forgot to patch the command-line help. Hope it helps.
>
>>>
>>> Recently, SPICE included the lz4 compression algorithm. This patch adds
>>> a command line option to select it.
>>
>> How is libvirt going to introspect whether the command line supports
>> this option? Is there some QMP command that lists the set of valid
>> compression formats understood by a given qemu binary?
No, patching the command line --help does NOT help libvirt. It needs to
be discoverable via QMP to be introspectible, as scraping --help output
is not machine-friendly. (That said, you DO want to expose it in --help
output; I'm just complaining that --help output alone is not enough).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-01-26 16:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 10:50 [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE Javier Celaya
2015-01-08 11:28 ` Gerd Hoffmann
2015-01-08 11:48 ` [Qemu-devel] [Spice-devel] " Fabio Fantoni
2015-01-08 12:00 ` Javier Celaya
2015-01-20 16:08 ` Christophe Fergeau
2015-01-23 14:06 ` Javier Celaya
2015-01-23 16:25 ` Eric Blake
2015-01-26 8:48 ` Javier Celaya
2015-01-26 16:25 ` Eric Blake [this message]
2015-01-27 8:26 ` Markus Armbruster
2015-01-28 16:54 ` Javier Celaya
2015-01-28 19:08 ` Markus Armbruster
2015-07-24 14:12 ` Fabio Fantoni
2015-07-27 6:12 ` Markus Armbruster
2015-10-09 6:45 ` Fabio Fantoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C66A60.3000204@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@amazon.com \
--cc=devel@flexvm.es \
--cc=javier.celaya@flexvm.es \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).