From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFmTr-0004yj-00 for qemu-devel@nongnu.org; Mon, 26 Jan 2015 11:25:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFmTm-0006cb-0I for qemu-devel@nongnu.org; Mon, 26 Jan 2015 11:25:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFmTl-0006cM-OS for qemu-devel@nongnu.org; Mon, 26 Jan 2015 11:25:33 -0500 Message-ID: <54C66A60.3000204@redhat.com> Date: Mon, 26 Jan 2015 09:25:04 -0700 From: Eric Blake MIME-Version: 1.0 References: <1508539.cfTQauU1Ry@javinlg> <17343709.DGNVESbVIr@javinlg> <54C27602.5070500@redhat.com> <158031087.SthlJV7jIF@javinlg> In-Reply-To: <158031087.SthlJV7jIF@javinlg> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q6hJHT82KXxWRHhpiCm2QwcN8ntvPGiie" Subject: Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Javier Celaya , spice-devel Cc: devel@flexvm.es, Gerd Hoffmann , Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --q6hJHT82KXxWRHhpiCm2QwcN8ntvPGiie Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2015 01:48 AM, Javier Celaya wrote: > Sorry, I forgot to patch the command-line help. Hope it helps. >=20 >>> >>> Recently, SPICE included the lz4 compression algorithm. This patch ad= ds >>> a command line option to select it. >> >> How is libvirt going to introspect whether the command line supports >> this option? Is there some QMP command that lists the set of valid >> compression formats understood by a given qemu binary? No, patching the command line --help does NOT help libvirt. It needs to be discoverable via QMP to be introspectible, as scraping --help output is not machine-friendly. (That said, you DO want to expose it in --help output; I'm just complaining that --help output alone is not enough). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --q6hJHT82KXxWRHhpiCm2QwcN8ntvPGiie Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUxmpgAAoJEKeha0olJ0NqZFcIAJ0W0M8/lFs4nLJUWubE1xrm K0j7mNsu6DJVrXQGsKAVTZUKB+gDowCA/pDB7k34md1i736+pNm588f+sBIo621x bpPC/x5lHQRkDTfrMxETDKOFRbBzL2c998+RSXjPeVbj5/TBa0lELjjSU5y8ME7j gTreX2V3LgCAIQM61yl1lzNcIPrc5m6cUiGq2P7wMVQukyPVObe6/NjeqJmk37s6 esHnd5b1rob5C98Wz88vOl8kYAYZtWemDsuim2OT1/VJWLD6cdPDAncL7r3Ei2lm 4ex0u7c80PQr9X3a/AQG9dQOD4w6DvabVEfot/flYttPM1QIZox0L6i8LeiyQUY= =zIw5 -----END PGP SIGNATURE----- --q6hJHT82KXxWRHhpiCm2QwcN8ntvPGiie--