Re: [Qemu-devel] [PATCH v2] vhost-user: add multi queue support

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2280 bytes --]

On 01/24/2015 05:22 AM, Nikolay Nikolaev wrote:
> Vhost-user will implement the multiqueueu support in a similar way to what

s/multiqueueu/multiqueue/

Also, you probably want to be consistent - is it two words (subject
line) or one word (this sentence)?  I could go either way.

> vhost already has - a separate thread for each queue.
> 
> To enable the multiqueue funcionality - a new command line parameter

s/funcionality/functionality/

> "queues" is introduced for the vhost-user netdev.
> 
> Changes since v1:
>  - use s->nc.info_str when bringing up/down the backend

This paragraph about path versioning belongs...

> 
> Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
> ---

...here, after the --- separator.  It is useful to reviewers, but makes
no sense in the final qemu.git repository (a year from now, we only care
about the one version that got committed, not how many tries it took to
get to that one version).

>  docs/specs/vhost-user.txt |    5 +++++
>  hw/virtio/vhost-user.c    |    6 +++++-
>  net/vhost-user.c          |   39 +++++++++++++++++++++++++--------------
>  qapi-schema.json          |    6 +++++-
>  qemu-options.hx           |    5 +++--
>  5 files changed, 43 insertions(+), 18 deletions(-)
> 
> diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt
> index 650bb18..d7b208c 100644
> --- a/docs/specs/vhost-user.txt
> +++ b/docs/specs/vhost-user.txt
> @@ -127,6 +127,11 @@ in the ancillary data:
>  If Master is unable to send the full message or receives a wrong reply it will
>  close the connection. An optional reconnection mechanism can be implemented.
>  
> +Multi queue suport

s/suport/support/

> +---------------------

Make the length of this separator match the text it is underlining (too
long, even after the typo fix)

> +++ b/qapi-schema.json
> @@ -2287,12 +2287,16 @@
>  #
>  # @vhostforce: #optional vhost on for non-MSIX virtio guests (default: false).
>  #
> +# @queues: #optional number of queues to be created for multiqueue vhost-user
> +#          (Since 2.3)

Might be worth mentioning that the default is 1.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]