From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFokf-0006rJ-PG for qemu-devel@nongnu.org; Mon, 26 Jan 2015 13:51:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFokb-0006eb-6h for qemu-devel@nongnu.org; Mon, 26 Jan 2015 13:51:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFoka-0006eU-V1 for qemu-devel@nongnu.org; Mon, 26 Jan 2015 13:51:05 -0500 Message-ID: <54C68C94.9030300@redhat.com> Date: Mon, 26 Jan 2015 11:51:00 -0700 From: Eric Blake MIME-Version: 1.0 References: <20150124121851.4278.77991.stgit@s440> In-Reply-To: <20150124121851.4278.77991.stgit@s440> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KJCqOirmMdHJfAJFd2eMtOOBd7SReDKHA" Subject: Re: [Qemu-devel] [PATCH v2] vhost-user: add multi queue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikolay Nikolaev , thomas.long@intel.com, snabb-devel@googlegroups.com, qemu-devel@nongnu.org, mst@redhat.com Cc: tech@virtualopensystems.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KJCqOirmMdHJfAJFd2eMtOOBd7SReDKHA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/24/2015 05:22 AM, Nikolay Nikolaev wrote: > Vhost-user will implement the multiqueueu support in a similar way to w= hat s/multiqueueu/multiqueue/ Also, you probably want to be consistent - is it two words (subject line) or one word (this sentence)? I could go either way. > vhost already has - a separate thread for each queue. >=20 > To enable the multiqueue funcionality - a new command line parameter s/funcionality/functionality/ > "queues" is introduced for the vhost-user netdev. >=20 > Changes since v1: > - use s->nc.info_str when bringing up/down the backend This paragraph about path versioning belongs... >=20 > Signed-off-by: Nikolay Nikolaev > --- =2E..here, after the --- separator. It is useful to reviewers, but makes= no sense in the final qemu.git repository (a year from now, we only care about the one version that got committed, not how many tries it took to get to that one version). > docs/specs/vhost-user.txt | 5 +++++ > hw/virtio/vhost-user.c | 6 +++++- > net/vhost-user.c | 39 +++++++++++++++++++++++++------------= -- > qapi-schema.json | 6 +++++- > qemu-options.hx | 5 +++-- > 5 files changed, 43 insertions(+), 18 deletions(-) >=20 > diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt > index 650bb18..d7b208c 100644 > --- a/docs/specs/vhost-user.txt > +++ b/docs/specs/vhost-user.txt > @@ -127,6 +127,11 @@ in the ancillary data: > If Master is unable to send the full message or receives a wrong reply= it will > close the connection. An optional reconnection mechanism can be implem= ented. > =20 > +Multi queue suport s/suport/support/ > +--------------------- Make the length of this separator match the text it is underlining (too long, even after the typo fix) > +++ b/qapi-schema.json > @@ -2287,12 +2287,16 @@ > # > # @vhostforce: #optional vhost on for non-MSIX virtio guests (default:= false). > # > +# @queues: #optional number of queues to be created for multiqueue vho= st-user > +# (Since 2.3) Might be worth mentioning that the default is 1. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KJCqOirmMdHJfAJFd2eMtOOBd7SReDKHA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUxoyUAAoJEKeha0olJ0NqWVcH/2kZ7AD4WxqNNrcyoLMJLT4t jYqVGKqBjLDRvqd9ejR8cYqrQ8sONRTxM0IA9yavGSpUngUjEmtwsaV0uRAnSG7D E5BCt5NAjOBWFgRrQWfmJx/IzJnnVGJxikdNoDoe6FaWYcfxfgPRjACjfIqvm2pg 4Svw8UGxKe138BCtyn66iNvsFO/xuf9q6wv79ct0COZ1qKK/Jxtdc4gnKxRwBh9H kffIl7XY9CbWZ/d8/bTdKKAnShI1L2TEsxI52yBr8qToUqwKa5hL7ZMgnrlGpS35 y9KXORhcDHrHu/H6BLmE4zMXMAN8npYv70UCYoT2RDmP4UBeH+uwnfTCu83OTuc= =sZZu -----END PGP SIGNATURE----- --KJCqOirmMdHJfAJFd2eMtOOBd7SReDKHA--