From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59300)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YFqBa-0000qR-1V
	for qemu-devel@nongnu.org; Mon, 26 Jan 2015 15:23:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YFqBX-0002tu-Bl
	for qemu-devel@nongnu.org; Mon, 26 Jan 2015 15:23:01 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45502)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YFqBX-0002to-3R
	for qemu-devel@nongnu.org; Mon, 26 Jan 2015 15:22:59 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0QKMwCr003762
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Mon, 26 Jan 2015 15:22:58 -0500
Message-ID: <54C6A220.1060701@redhat.com>
Date: Mon, 26 Jan 2015 15:22:56 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1421397983-28065-1-git-send-email-famz@redhat.com>
	<1421397983-28065-3-git-send-email-famz@redhat.com>
In-Reply-To: <1421397983-28065-3-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 2/5] qtest: Add scripts/qtest.py
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 2015-01-16 at 03:46, Fam Zheng wrote:
> This adds scripts/qtest.py as a python library for qtest protocol.
>
> This is a skeleton with a basic "cmd" method to execute a command,
> reading and parsing of qtest output could be added later on demand.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   scripts/qtest.py | 71 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 71 insertions(+)
>   create mode 100644 scripts/qtest.py
>
> diff --git a/scripts/qtest.py b/scripts/qtest.py
> new file mode 100644
> index 0000000..25391f5
> --- /dev/null
> +++ b/scripts/qtest.py
> @@ -0,0 +1,71 @@
> +# QEMU qtest library
> +#
> +# Copyright (C) 2015 Red Hat Inc.
> +#
> +# Authors:
> +#  Fam Zheng <famz@redhat.com>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2.  See
> +# the COPYING file in the top-level directory.
> +#
> +# Based on qmp.py.
> +#
> +
> +import errno
> +import socket
> +
> +class QEMUQtestProtocol(object):
> +    def __init__(self, address, server=False):
> +        """
> +        Create a QEMUQtestProtocol object.
> +
> +        @param address: QEMU address, can be either a unix socket path (string)
> +                        or a tuple in the form ( address, port ) for a TCP
> +                        connection
> +        @param server: server mode listens on the socket (bool)

Maybe you could add a comma here ("server mode, listens...").

With or without:

Reviewed-by: Max Reitz <mreitz@redhat.com>